Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

[Ralph Corderoy]

Hi,

Werner wrote:
> Thanks, this is fine now.  A minor issue:
> 
> +     -test -d "$(DESTDIR)$(bindir)" || \
> +             $(mkinstalldirs) "$(DESTDIR)$(bindir)";
> 
> If you break a line, please start the new line with the operator:
> 
>   -test -d "$(DESTDIR)$(bindir)" \
>            || $(mkinstalldirs) "$(DESTDIR)$(bindir)";

(Interesting.  I have binary operators at the end of the line as, like a
hyphen in text, they indicate there's more to follow.)

> Well, if a line gets continued with `\', no tabs are necessary.  Ah, I
> now see that you've removed the line continuation mark, so this line:
> 
>               $(srcdir)/grog.pl >$@;
>       chmod +x $@;
> 
> should rather be
> 
>               $(srcdir)/grog.pl >$@; \
>       chmod +x $@;

The former will have make(1) stop if grog.pl fails whereas the latter
will ignore that and use chmod's success.  `&&' would avoid this in the
latter though I wonder, without context, if the two commands need to be
in the one sh invocation?  Both create $@ even on failure, perhaps
causing the target to be considered `built' next time.  `grog.pl >address@hidden
&& mv address@hidden $@' might help.

Cheers, Ralph.