Re: [Groff] cvs 2009-06-25 does not build on MacOS 10.5.7

[Werner LEMBERG]

> gcc version 4.0.1 (Apple Inc. build 5488)

This is ooold.

>> Hmm.  Maybe a bug in the compiler?  Try to remove the `inline' keyword
>> from
>>
>>  inline node::~node()
>>  {
>>    ...
>>
>> around line 1814 in src/roff/troff/node.cpp.
> 
> It builds without "inline".

Ah, so it's definitely a compiler problem.

> In the meantime I have updated the compiler to
> 
> gcc version 4.0.1 (Apple Inc. build 5493)
> gcc version 4.2.1 (Apple Inc. build 5574)
> 
> Neither version compiles the "inline" version.

Apparently, this has been fixed in gcc 4.3.  Here's a possible
reference to the problem:

  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=400332

Theoretically the (untested) patch below should make it compile.
Please test.


    Werner


======================================================================


--- node.h.old  2009-04-10 19:27:38.000000000 +0200
+++ node.h      2009-07-18 09:26:50.000000000 +0200
@@ -59,7 +59,7 @@
   node(node *, statem *, int);
   node *add_char(charinfo *, environment *, hunits *, int *, node ** = 0);

-  virtual ~node();
+  inline virtual ~node();
   virtual node *copy() = 0;
   virtual int set_unformat_flag();
   virtual int force_tprint() = 0;