Re: [Groff] pic bug between 1.18.1 and 1.19.x

[Werner LEMBERG]

> I've run pic from groff-1.18.1.1 on my extracted test file.
> Then I ran pic from groff-1.19.2pre.  [...]
>
> But, the .sp -1 lines are missing in 1.19.2pre and causing all the
> trouble obviously.

I don't think so.  This very change, I think, is the cause of the
problem:

> -    printf("\\D'f %du'\\h'%du'\n.sp -1\n", int(f*FILL_MAX), 
> -int(f*FILL_MAX));
> +    // \D'Fg ...' emits a node only in compatibility mode,
> +    // thus we add a dummy node
> +    printf("\\&\\D'Fg %.3f'\n.sp -1\n", 1.0 - f);

It makes behave pic the same in compatibility mode and in normal groff
mode.

> Werner, you know the best why the change was made in the first
> place.  Do you find this fix correct?  Is it safe to assume it won't
> spoil other things?

I don't like your fix, sorry.  It seems that gpresent relies on
internals of pic which have changed.

BTW, I've just changed PIC to emit `.gcolor' and `.fcolor' instead of
\m and \M, respectively.


    Werner