Re: [Groff] status of pdfmark macros

[Keith Marshall]

On Sunday 27 February 2005 9:07 am, Werner LEMBERG wrote:
> > I've attached the update as a tarball containing the two new files,
> > `pdfroff.sh' and `pdfroff.man', together with a patch against the
> > CVS versions on which my additional modifications are based
>
> Only the attachment with the two new files have been sent to the
> mailing list; the patch file is missing.  Please resend.

The patch file was also included in the tarball, along with the two new 
files.  Sorry if this wasn't clear, from my earlier post.  In any case, I've 
modified it, in line with your comments below -- the update is attached.

> Some comments:
> >         * aclocal.m4: (GROFF_APPRESDIR_OPTION): use AC_HELP_STRING
> >         instead of AS_HELP_STRING.
> > [...]
> >         * configure.ac: Add AC_PREREQ(2.56),
>
> autoconf 2.56 is too old; you need 2.59 to have the `abs_xxx_dir'
> variables work correctly.  As a consequence, I don't have to use
> AC_HELP_STRING which is now marked as obsolete.  I will do those fixes
> by myself.

Ok.  I had used 2.56, on my Win32 box, without any problem other than the 
absence of AS_HELP_STRING.  On my Linux box I had 2.52, which quite happily 
generated an updated `configure', with no warnings or errors whatsoever -- 
however, the Makefile produced when I ran configure was hopelessly broken!
I fixed this by upgrading immediately to 2.59, but it was the absense of any 
warning from 2.52 that prompted me to add the AC_PREREQ, and, since I had had 
previous success with 2.56, after replacing AS_HELP_STRING with 
AC_HELP_STRING, I chose to make that the AC_PREREQ cut off version.

I hadn't seen any reference to AS_HELP_STRING in either the release notes, or 
the HTML version of the 2.59 documentation.  However, have now checked the 
info version of the docs, I see why you prefer to use AS_HELP_STRING.  
Consequently, I have modified my patch to set AC_PREREQ(2.59), and to use 
AS_HELP_STRING instead of AC_HELP_STRING throughout.

> > (For your possible convenience, I've included the above as ChangeLog
> > patches, in the overall patch file).
>
> Please don't do that in future postings.  What you've done in your
> mail is the right solution and fully sufficient: ChangeLog entries
> should always be sent separately so that the patch applies cleanly
> even if there have been other changes meanwhile (which normally
> produce new entries in the ChangeLog file).

Some project admins ask for ChangeLog updates along with patches, so I 
thought this might be helpful.  On thinking about it, I understand why 
including this info in a global patch file isn't such a good idea, so I have 
removed this from the revised patch, attached.  All other changes, as noted 
in my previous post, remain in place, with the exception of the replacement 
of AC_HELP_STRING in aclocal.m4, and the change to AC_PREREQ(2.59) in 
configure.ac, as noted above.

Best regards,
Keith.

groff-200502280310.patch.bz2
Description: BZip2 compressed data