[Groff] afmtodit problems - man page not updated

[Michail Vidiassov]

Dear Werner,

On Tue, 28 Oct 2003, Werner LEMBERG wrote:

> Now I understand.  You've found a bug -- I still think that the
> wording in the man page is valid.  I've applied your patch, thanks.
>

May be the wording of the man page WAS valid.
But now it (still) says

 If a PostScript character is in the encoding to be used  for  the  font
 but  is  not  mentioned  in  map_file, or if a generic groff glyph name
 can't be deduced using the Adobe Glyph List (built into afmtodit)  then
 afmtodit  will  put  it in the groff font file as an unnamed character,

while now afmtodit (CVS) assigns glyph names (from textmap, AGL, generic)
regardless of a PS character being in the encoding or not.

Example:

test.afm
-----------
StartFontMetrics        4.1
FontName        TestFont
ItalicAngle     0
StartCharMetrics        4
C       32      ;       WX      250     ;       N       space   ;       B
C       255     ;       WX      500     ;       N       afii10097       ;
C       -1      ;       WX      514     ;       N       afii10194       ;
C       -1      ;       WX      561     ;       N       uni044A ;       B
EndCharMetrics
EndFontMetrics
------------
command line
./afmtodit test.afm textmap TEST
------------
TEST
-----------
name TEST
internalname TestFont
spacewidth 250
charset
space   250     0       32      space
u044F   500,639 3       255     afii10097
u044A   561,639 3       256     uni044A
u0463   514,799 3       257     afii10194
-------------

Note two afii* characters. One was in PS encoding, the other was not.
But both were put in the groff font file named.

Also, there is a tiny bug in the Makefile for afmtodit

--- src/utils/afmtodit/Makefile.sub.orig        Wed Feb 26 17:54:08 2003
+++ src/utils/afmtoditMakefile.sub      Thu Dec 11 11:57:20 2003
@@ -12,7 +12,7 @@
        else \
          sed -e "s|@VERSION@|$(version)$(revision)|" \
               -e "s|@FONTDIR@|$(fontdir)|" \
-              $(srcdir)/afmtodit.pl afmtodit; \
+              $(srcdir)/afmtodit.pl >afmtodit; \
        fi
        chmod +x afmtodit


                            Sincerely, Michail