groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Groff] asking for help


From: Ralph Corderoy
Subject: Re: [Groff] asking for help
Date: Fri, 13 Jul 2001 19:53:48 +0100

Hi Werner,

> The first parameter to open(2) looked dodgy.  To confirm I was looking
> at the right piece of source I added the two writes, again using the
> same variables, and it confirms they're 0.  So they're not getting set
> by the temporary filename code.

I took a look at xtmpfile.  This seems wrong to me.

    --- src/libs/libgroff/tmpfile.cc        12 Jul 2001 22:11:04 -0000      1.13
    +++ src/libs/libgroff/tmpfile.cc        13 Jul 2001 18:44:43 -0000
    @@ -183,7 +183,7 @@
     #endif /* not HAVE_MKSTEMP */
       if (do_unlink)
         add_tmp_file(templ);
    -  if ((namep != 0) && ((*namep) != 0))
    +  if (namep)
         *namep = templ;
       else
         a_delete templ;

If s == NULL and &s is passed into the routine then s won't be set to
templ.


Ralph.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]