[Groff] compilation failure in html.cc

[Gaius Mulley]

Lester (address@hidden) writes:


> gmake[2]: Entering directory `/tmp/groff-current/grohtml'
> c++ -I. -I. -I../include -I./../include -DHAVE_UNISTD_H=1 -DHAVE_DIRENT_H=1 
> -DHA
> VE_LIMITS_H=1 -DHAVE_STDLIB_H=1 -DSTDLIB_H_DECLARES_GETOPT=1 
> -DSTDLIB_H_DECLARES
> _PUTENV=1 -DSTDIO_H_DECLARES_POPEN=1 -DSTDIO_H_DECLARES_PCLOSE=1 
> -DHAVE_CC_LIMIT
> S_H=1 -DRETSIGTYPE=void -DHAVE_STRUCT_EXCEPTION=1 -DHAVE_UNISTD_H=1 
> -DHAVE_GETPA
> GESIZE=1 -DHAVE_MMAP=1 -DHAVE_FMOD=1 -DHAVE_STRTOL=1 -DHAVE_GETCWD=1 
> -DHAVE_STRE
> RROR=1 -DHAVE_PUTENV=1 -DHAVE_RENAME=1 -DHAVE_MKSTEMP=1  -g -O2  -c html.cc
> html.cc:4145: ANSI C++ forbids declaration `is_appropriate_to_start_table' 
> with 
> no type
> gmake[2]: *** [html.o] Error 1
> gmake[2]: Leaving directory `/tmp/groff-current/grohtml'
> gmake[1]: *** [grohtml] Error 2
> gmake[1]: Leaving directory `/tmp/groff-current'
> gmake: *** [all] Error 2

ahh yes, oops, the function declaration: is_appropriate_to_start_table
at line 4142 needs an int return value. Like this:

int html_printer::is_appropriate_to_start_table (struct text_defn *cols_1,
^^^                                              struct text_defn *cols_2,
                                                 struct text_defn *last_guess)

Below is a patch against the current CVS repository.
Thanks for detecting the problem.

cheers Gaius



diff -r -c groff-cvs/grohtml/html.cc groff-html/grohtml/html.cc
*** groff-cvs/grohtml/html.cc   Tue Dec 28 23:51:00 1999
--- groff-html/grohtml/html.cc  Thu Dec 30 10:39:41 1999
***************
*** 4139,4147 ****
   *                                  at this point.
   */
  
! html_printer::is_appropriate_to_start_table (struct text_defn *cols_1,
!                                            struct text_defn *cols_2,
!                                            struct text_defn *last_guess)
  {
    if (count_columns(last_guess) == 1) {
      if (debug_table_on) {
--- 4139,4147 ----
   *                                  at this point.
   */
  
! int html_printer::is_appropriate_to_start_table (struct text_defn *cols_1,
!                                                struct text_defn *cols_2,
!                                                struct text_defn *last_guess)
  {
    if (count_columns(last_guess) == 1) {
      if (debug_table_on) {