groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 03/14: [troff]: Fix `special` request without arguments.


From: G. Branden Robinson
Subject: [groff] 03/14: [troff]: Fix `special` request without arguments.
Date: Fri, 8 Dec 2023 18:15:28 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit 884e9035bc473f215cfd9b9f865fd29e50b0046d
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sat Dec 2 15:29:33 2023 -0600

    [troff]: Fix `special` request without arguments.
    
    * src/roff/troff/node.cpp (set_special_fonts): Revert part of commit
      44db6efc01, 3 November.  Stop throwing diagnostic and ignoring request
      if given no arguments; that's how you clear the global list of fonts
      designated as special by request (contrast with those that declare
      themselves as special in their description files).
---
 ChangeLog               | 9 +++++++++
 src/roff/troff/node.cpp | 6 ------
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index bb0f70c59..50f40e0b6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2023-12-02  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * src/roff/troff/node.cpp (set_special_fonts): Revert part of
+       commit 44db6efc01, 3 November.  Stop throwing diagnostic and
+       ignoring request if given no arguments; that's how you clear the
+       global list of fonts designated as special by request (contrast
+       with those that declare themselves as special in their
+       description files).
+
 2023-12-01  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        [troff]: Fix Savannah #64957 (`device`, `output` broken).
diff --git a/src/roff/troff/node.cpp b/src/roff/troff/node.cpp
index f785fc328..f97a79595 100644
--- a/src/roff/troff/node.cpp
+++ b/src/roff/troff/node.cpp
@@ -6364,12 +6364,6 @@ static void set_font_specific_special_fonts()
 
 static void set_special_fonts()
 {
-  if (!has_arg()) {
-    warning(WARN_MISSING, "global special font configuration request"
-           " expects one or more arguments");
-    skip_line();
-    return;
-  }
   read_special_fonts(&global_special_fonts);
   skip_line();
 }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]