groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 05/18: [troff]: Fix error in `pev` output.


From: G. Branden Robinson
Subject: [groff] 05/18: [troff]: Fix error in `pev` output.
Date: Tue, 25 Jul 2023 05:49:17 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit ab6f697840007ca3e8dc5c72f6b21b3ee595e75b
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Tue Jul 25 03:57:22 2023 -0500

    [troff]: Fix error in `pev` output.
    
    * src/roff/troff/env.cpp (environment::print_env): Fix error in report.
      The units of {minimum inter-word, additional inter-sentence} space
      size are 12ths of the font's "spacewidth" parameter, not 36ths of an
      em.
    
    Consider the following input.
    
    .\" groff -T ps -Z
    .nf
    foo bar1
    .ss 12
    foo bar2 \" cases 1 and 2 are the same
    foo\h'1m/3u'bar3 \" wider than 1 & 2
    foo\h'1m/36u*12u'bar4 \" slightly narrower than case 3
    .ss 11
    foo bar5 \" narrower than case 1 (as expected)
    foo\h'1m/36u*11u'bar6 \" between cases (1,2) and 4
---
 ChangeLog              | 19 +++++++++++++++++++
 src/roff/troff/env.cpp |  5 +++--
 2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0925a1dd9..0e6377b22 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,22 @@
+2023-07-25  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * src/roff/troff/env.cpp (environment::print_env): Fix error in
+       report.  The units of {minimum inter-word, additional
+       inter-sentence} space size are 12ths of the font's "spacewidth"
+       parameter, not 36ths of an em.
+
+       Consider the following input.
+         .\" groff -T ps -Z
+         .nf
+         foo bar1
+         .ss 12
+         foo bar2 \" cases 1 and 2 are the same
+         foo\h'1m/3u'bar3 \" wider than 1 & 2
+         foo\h'1m/36u*12u'bar4 \" slightly narrower than case 3
+         .ss 11
+         foo bar5 \" narrower than case 1 (as expected)
+         foo\h'1m/36u*11u'bar6 \" between cases (1,2) and 4
+
 2023-07-19  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * tmac/papersize.tmac: If not already defined, set `PO` register
diff --git a/src/roff/troff/env.cpp b/src/roff/troff/env.cpp
index ab214c764..e0b1b2892 100644
--- a/src/roff/troff/env.cpp
+++ b/src/roff/troff/env.cpp
@@ -3309,8 +3309,9 @@ void environment::print_env()
   errprint("  font number: %1\n", fontno);
   errprint("  previous family: '%1'\n", prev_family->nm.contents());
   errprint("  family: '%1'\n", family->nm.contents());
-  errprint("  space size: %1/36 em\n", space_size);
-  errprint("  sentence space size: %1/36 em\n", sentence_space_size);
+  errprint("  space size: %1/12 of font spacewidth\n", space_size);
+  errprint("  sentence space size: %1/12 of font spacewidth\n",
+          sentence_space_size);
   errprint("  previous line interrupted: %1\n",
           prev_line_interrupted ? "yes" : "no");
   errprint("  fill mode: %1\n", fill ? "on" : "off");



reply via email to

[Prev in Thread] Current Thread [Next in Thread]