[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[groff] 10/49: [troff]: Trivially refactor.
From: |
G. Branden Robinson |
Subject: |
[groff] 10/49: [troff]: Trivially refactor. |
Date: |
Sun, 25 Sep 2022 17:02:55 -0400 (EDT) |
gbranden pushed a commit to branch master
in repository groff.
commit 8c53f0c6294927684d5272c5a64c55f251d321f3
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Mon Sep 19 15:25:52 2022 -0500
[troff]: Trivially refactor.
* src/roff/troff/input.cpp (do_name_test): Boolify and rename local
variables to..."impredicate" their names.
- bad_char -> got_bad_char
- some_char -> got_some_char
---
ChangeLog | 9 +++++++++
src/roff/troff/input.cpp | 10 +++++-----
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 9a851d2dc..ff3eae867 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2022-09-19 G. Branden Robinson <g.branden.robinson@gmail.com>
+
+ [troff]: Trivially refactor.
+
+ * src/roff/troff/input.cpp (do_name_test): Boolify and rename
+ local variables to..."impredicate" their names.
+ - bad_char -> got_bad_char
+ - some_char -> got_some_char
+
2022-09-19 G. Branden Robinson <g.branden.robinson@gmail.com>
[grodvi, ...]: Trivially refactor.
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 61995fee5..c4b6bbc69 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -1511,8 +1511,8 @@ static int do_name_test()
token start;
start.next();
int start_level = input_stack::get_level();
- int bad_char = 0;
- int some_char = 0;
+ bool got_bad_char = false;
+ bool got_some_char = false;
for (;;) {
tok.next();
if (tok.is_newline() || tok.is_eof()) {
@@ -1526,10 +1526,10 @@ static int do_name_test()
&& (compatible_flag || input_stack::get_level() == start_level))
break;
if (!tok.ch())
- bad_char = 1;
- some_char = 1;
+ got_bad_char = true;
+ got_some_char = true;
}
- return some_char && !bad_char;
+ return (got_some_char && !got_bad_char);
}
static int do_expr_test()
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [groff] 10/49: [troff]: Trivially refactor.,
G. Branden Robinson <=