groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 02/02: Fix nits.


From: G. Branden Robinson
Subject: [groff] 02/02: Fix nits.
Date: Thu, 21 May 2020 08:19:30 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit bbdf8b1349698076c59a59b6ee1f6509631af02d
Author: G. Branden Robinson <address@hidden>
AuthorDate: Thu May 21 20:48:47 2020 +1000

    Fix nits.
    
    * NEWS: Fix missing comma.  Remove excess precision from claim about
      Ossanna's troff.  It was in development since "about 1973" per CSTR
      #97, so stop pinning the date of its implementation details to when
      its manual was published.
    
    * Add Savannah ticket numbers to regression tests so the information is
      not lost if the test files are renamed.
---
 NEWS                                              | 8 ++++----
 src/roff/groff/tests/regression_savannah_56555.sh | 1 +
 src/roff/groff/tests/regression_savannah_58153.sh | 1 +
 src/roff/groff/tests/regression_savannah_58337.sh | 2 +-
 4 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/NEWS b/NEWS
index db4ddc6..5e53dfc 100644
--- a/NEWS
+++ b/NEWS
@@ -20,12 +20,12 @@ o A new read-only register ".cp" is implemented.  Within a 
.do request,
 
 o Point-size escapes of the form '\sNN', where NN is in the range 10-39,
   are now recognized only in compatibility mode (groff -C); when
-  encountered an error diagnostic is emitted.  In normal mode, \sN is
+  encountered, an error diagnostic is emitted.  In normal mode, \sN is
   interpreted as setting the point size to the single digit value N,
   which ends the escape.  This change eliminates a quirk in the language
-  grammar that dates back to 1976 (AT&T troff by Ossanna) but apparently
-  was not documented until 1992 when Kernighan updated CSTR #54 for AT&T
-  troff.
+  grammar that dates back to the mid-1970s (AT&T troff by Ossanna) but
+  apparently was not documented until 1992 when Kernighan updated CSTR
+  #54 for AT&T troff.
 
   The form '\s(NN' is accepted for two-digit point sizes in all known
   troffs.  The form '\s[NNN]' accepts a numeric expression of variable
diff --git a/src/roff/groff/tests/regression_savannah_56555.sh 
b/src/roff/groff/tests/regression_savannah_56555.sh
index 009990b..4a99da3 100755
--- a/src/roff/groff/tests/regression_savannah_56555.sh
+++ b/src/roff/groff/tests/regression_savannah_56555.sh
@@ -21,6 +21,7 @@
 groff="${abs_top_builddir:-.}/test-groff"
 
 # Check for segfault if we try to write a glyph before setting up.
+# Savannah #56555.
 "$groff" >/dev/null <<EOF
 \!ta
 EOF
diff --git a/src/roff/groff/tests/regression_savannah_58153.sh 
b/src/roff/groff/tests/regression_savannah_58153.sh
index 0c48bd5..b350a7a 100755
--- a/src/roff/groff/tests/regression_savannah_58153.sh
+++ b/src/roff/groff/tests/regression_savannah_58153.sh
@@ -21,6 +21,7 @@
 groff="${abs_top_builddir:-.}/test-groff"
 
 # Ensure that we get backtrace output across file and pipe boundaries.
+# Savannah #58153.
 OUT=$("$groff" -U 2>&1 >/dev/null <<EOF
 .pso printf '\\\s[-20]\\\n'
 EOF
diff --git a/src/roff/groff/tests/regression_savannah_58337.sh 
b/src/roff/groff/tests/regression_savannah_58337.sh
index 55883bf..7928651 100755
--- a/src/roff/groff/tests/regression_savannah_58337.sh
+++ b/src/roff/groff/tests/regression_savannah_58337.sh
@@ -24,7 +24,7 @@ set -e
 
 # groff should ignore negative inter-word and inter-sentence space
 # sizes.  And certainly not fail an assertion.  Savannah #58337.
-"$groff" -Tascii  <<EOF | grep -Fqx 'A B.  C.'
+"$groff" -Tascii <<EOF | grep -Fqx 'A B.  C.'
 .pl 1v
 .ss -1 -1
 A B.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]