Re: [gpsd-users] Build broken for non-QT

[O'Connor, Daniel]

> On 14 Jan 2015, at 01:39, Greg Troxel <address@hidden> wrote:
> "O'Connor, Daniel" <address@hidden> writes:
> 
> 
>> -    if config.CheckHeader(["sys/time.h", "sys/timepps.h"]):
>> +    if env['pps'] and env['ntpshm'] and config.CheckHeader(["sys/types.h", 
>> "sys/time.h", "sys/timepps.h"]):
>>         confdefs.append("#define HAVE_SYS_TIMEPPS_H 1\n")
>>         kpps = True
> 
> Why is the check for timepps.h condition on ntpshm?  How gpsd emits time
> should have nothing to do with using the kernel feature.  This should
> not go in.
> 
> 
> Also, please don't make unrelated changes in a commit.

Sorry, I forgot to edit the patch before attaching it, that part shouldn't go 
in :)

--
Daniel O'Connor
"The nice thing about standards is that there
are so many of them to choose from."
 -- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C