Re: [gpsd-users] FreeBSD and sys/timepps.h

[Eric S. Raymond]

Greg Troxel <address@hidden>:
> 
> "O'Connor, Daniel" <address@hidden> writes:
> 
> > +++ SConstruct  2015-01-06 14:20:31.594917587 +1030@@ -517,7 +509,7 @@
> >      env["bluez"] = False
> >
> >  # ntpshm is required for pps support
> > -if env['pps'] and env['ntpshm'] and config.CheckHeader("sys/timepps.h"):
> > +if env['pps'] and env['ntpshm'] and (config.CheckHeader("sys/timepps.h") 
> > or os.uname()[0] == "FreeBSD"):
> >      confdefs.append("#define HAVE_SYS_TIMEPPS_H 1\n")
> >      announce("You have kernel PPS available.")
> >  else:
> 
> I think it's best to avoid os-specific kludges.  It would be far better
> to make scons do the right thing, perhaps by checking for sys/types
> earlier.   I wouldn't be surprised if it's ok to always include
> sys/types.h before sys/timepps.h, on all platforms.

I concor with all of this.
 
> FWIW, the current code builds on NetBSD (not sure why since the PPS code
> has common ancestry, I think).
> 
> You will find that pps won't work once you get past this, though,
> because the current code assumes the Linux flavor of PPS (not the
> IETF-specificed one) is always present.  (It will build, because I fixed
> the ifdefs, but the logic is still wrong.)   There are comments in the
> file about this.

Is there any near-term prospect of this being fixed?  As in, should
I hold releasing on it?
-- 
                <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>

signature.asc
Description: Digital signature