Re: gpsd | Pipeline #135104296 has failed for master | b30ab488

[Bernd Zeimetz]

On 4/13/20 8:52 PM, Gary E. Miller wrote:

> sparc64 binary debugging is not in my skill set.  If no one that
> has that skill cares, I'll just mark that to be ignored.

Running gpsfake with python3 actually shows the issue:

Traceback (most recent call last):
  File "/srv/bzed/gpsd/gpsfake", line 285, in <module>
    test.gps_add(logfile, speed=speed, pred=fakehook,
  File "/srv/bzed/gpsd/gps/fake.py", line 652, in gps_add
    testload = TestLoad(logfile, predump=self.predump, slow=self.slow,
  File "/srv/bzed/gpsd/gps/fake.py", line 168, in __init__
    (plen, ptype, packet, _counter) = getter.get(logfp.fileno())
  File "/srv/bzed/gpsd/gps/packet.py", line 155, in get
    packet += chr(_loaded.outbuffer[octet])
IndexError: invalid index


The reason here is obvious:

_buffer_size = ctypes.c_int.in_dll(_packet, "fvi_size_buffer").value


fvi_size_buffer is size_t and not an int, so _buffer_size was 0 instead
of MAX_PACKET_LENGTH *2+1.


Fixed by

commit 4895c1a52122df948f4d2a9e266ea040f561d032
Author: Bernd Zeimetz <address@hidden>
Date:   Mon May 4 14:49:42 2020 +0200

    fvi_size_lexer/fvi_size_buffer are size_t.




-- 
 Bernd Zeimetz                            Debian GNU/Linux Developer
 http://bzed.de                                http://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485  DD95 EB36 171A 6FF9 435F