Re: [gpsd-dev] cfmakeraw part 2

[Gary E. Miller]

Yo Greg!

On Thu, 20 Jun 2019 14:38:17 -0400
Greg Troxel <address@hidden> wrote:

> >> These days, most of the Solaris codebase lives on (as Free
> >> Software) under the name Illumos.  A variant of that, SmartOS, is
> >> used by joyent in their cloud offering, and that uses pkgsrc as
> >> the standard packaging system.  So we have a lot of fixes found by
> >> building on Solaris, while which I'm sure include some Solaris
> >> bugs, seem to be mostly beyond-POSIX assumptions.  
> >
> > Yes, but can we test it?  Guessing at fixes is dangerous and
> > wasteful.  
> 
> I am not guessing.  I am moving a fix that was added to pkgsrc to gpsd
> proper, believing that the person who added it was not confused, and
> that their implied report that this moved gpsd from "not building" to
> "building" was correct.  I sent a blog post about non-portable
> cfmakeraw usage earlier.

OK, not a guess, but still untested.  I'd still rather test for
cfmakeraw() instead of anecdotal heuristics.  For after release.

> Plus, it amounts to "|| defined(__sun)" in two places, mirroring
> cygwin.

Yes, that one is low risk.

> > Looking at the Illumos site I don't see how gpsd could ever run on
> > that.  
> 
> I don't see why you say that.  It runs on regular computers and more
> or less follows posix.  (I am not saying that is clear from the site,
> or that I've tried it).

We'll have to disagree on that.  Until someone can prove it.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

pgpaezVeXqJbF.pgp
Description: OpenPGP digital signature