Re: [PATCH] NSBox - user colors

[Jeff Teunissen]

Fred Kiefer wrote:

[snip]

> I am wondering why your patch replaces NSFrameRect with direct drawing
> code.

No particular reason, really. Just seemed the right thing to do.

> I am also unsure, if your code draws correctly on flipped views.

I am sure that it would not look correct on flipped views, but NSBox is not
flipped. It'd be a trivial addition to handle it, though, just two more
variables and two ifs.

> But my main concern is, if this code has the right correspondance
> between the system colours and the border elements. Could you verify
> this code against either OpenStep or Cocoa or would the adaptable
> colours be a GNUstep specific feature?

Named colors originated in OPENSTEP, and could only be changed on Windows
(where their values came from the Registry). So yes, I would consider them a
GNUstep-specific feature.

As for the names of the colors used, the control* colors are the only group
that has named colors with the values that we're looking for for the look.

NSBox needs a light highlight, a shadow, and a dark shadow. Outside control*
you have only highlight and shadow (which is black, not the dark gray we
want).

-- 
| Jeff Teunissen  -=-  Pres., Dusk To Dawn Computing  -=-  deek @ d2dc.net
| GPG: 1024D/9840105A   7102 808A 7733 C2F3 097B  161B 9222 DAB8 9840 105A
| Core developer, The QuakeForge Project        http://www.quakeforge.net/
| Specializing in Debian GNU/Linux              http://www.d2dc.net/~deek/