[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH/RFC] gsweb GSWApplication.. preparation for GSW/WO-Names
From: |
David Ayers |
Subject: |
[PATCH/RFC] gsweb GSWApplication.. preparation for GSW/WO-Names |
Date: |
Thu, 05 Dec 2002 18:38:27 +0100 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2) Gecko/20021126 |
Hello everyone,
this patch is only a minor preparation for the following GSW/WO patches.
GSWeb.framework/GSWApplication
don't use NSClassFromString to support GSW & WO namespaces
Cheers,
Dave
PS: I'm not sure how to break down my next patch (GSW/WO-names) into
smaller units. It might make sense to prepare a branch or at least a
tag before it's applied. So if anyone still has something they want to
commit, it might be good if you can do it soon, while I still try to
clean up the last bit of my gsweb.make, gsweb_wo.make and config.mak
stuff before posting the large patch.
I'll try to explain it in detail with the actual post but the main point
is to split gsweb into 2 sets of frameworks each with thier own class
hierarchy compiled from the same source. You will be able to determine
during configure whether to build only one of these by default, but will
be able to build the other or both by make parameter at anytime. This
first patch will mainly change the configuration, Makefiles and headers
inclusions (this affects allmost every *.m file!). Later patches will
start flushing out the current dynamic name usage within the framework.
If there are any comments allready, please tell me now so that I might
be able to take them into account, before posting the large patch.
Index: dev-libs/gsweb/GSWeb.framework/GSWApplication.m
===================================================================
RCS file:
/cvsroot/gnustep/gnustep/dev-libs/gsweb/GSWeb.framework/GSWApplication.m,v
retrieving revision 1.40
diff -u -r1.40 GSWApplication.m
--- dev-libs/gsweb/GSWeb.framework/GSWApplication.m 2 Dec 2002 22:00:20
-0000 1.40
+++ dev-libs/gsweb/GSWeb.framework/GSWApplication.m 5 Dec 2002 17:18:40
-0000
@@ -2236,7 +2255,7 @@
elementClass=NSClassFromString(aName);
NSDebugMLLog(@"info",@"elementClass %p:%@",elementClass,elementClass);
NSDebugMLLog(@"info",@"elementClass superClass:%@",[elementClass
superClass]);
- if (elementClass &&
!ClassIsKindOfClass(elementClass,NSClassFromString(@"GSWComponent")))
+ if (elementClass && !ClassIsKindOfClass(elementClass,[GSWComponent class]))
{
NSDebugMLLog(@"info",@"CREATE Element of Class %p:%@",aName,aName);
element=[[[elementClass alloc] initWithName:aName
@@ -4674,7 +4690,7 @@
}
else
{
- Class GSWComponentClass=NSClassFromString(@"GSWComponent");
+ Class GSWComponentClass=[GSWComponent class]);
if (!ClassIsKindOfClass(aClass,GSWComponentClass))
{
NSDebugMLLog0(@"application",@"component class is not a kind
of GSWComponent\n");
@@ -4816,7 +4832,7 @@
}
else
{
- Class GSWElementClass=NSClassFromString(@"GSWElement");
+ Class GSWElementClass=[GSWElement class]);
if (!ClassIsKindOfClass(aClass,GSWElementClass))
{
ExceptionRaise(@"GSWApplication",
- [PATCH/RFC] gsweb GSWApplication.. preparation for GSW/WO-Names,
David Ayers <=