[taler-wallet-core] branch master updated: harness: test for wire fee handling

[gnunet]

This is an automated email from the git hooks/post-receive script.

dold pushed a commit to branch master
in repository wallet-core.

The following commit(s) were added to refs/heads/master by this push:
     new c1f4f63e0 harness: test for wire fee handling
c1f4f63e0 is described below

commit c1f4f63e0b2bfd0e4cc935943caa80118a5124ac
Author: Florian Dold <florian@dold.me>
AuthorDate: Thu Mar 7 14:23:01 2024 +0100

    harness: test for wire fee handling
---
 packages/taler-harness/src/harness/harness.ts      |   6 +-
 .../src/integrationtests/test-wallet-wirefees.ts   | 169 +++++++++++++++++++++
 .../src/integrationtests/testrunner.ts             |   2 +
 3 files changed, 176 insertions(+), 1 deletion(-)

diff --git a/packages/taler-harness/src/harness/harness.ts 
b/packages/taler-harness/src/harness/harness.ts
index 831d4ab3c..d80fc8b33 100644
--- a/packages/taler-harness/src/harness/harness.ts
+++ b/packages/taler-harness/src/harness/harness.ts
@@ -904,6 +904,7 @@ export interface ExchangeConfig {
   httpPort: number;
   database: string;
   overrideTestDir?: string;
+  overrideWireFee?: string;
 }
 
 export interface ExchangeServiceInterface {
@@ -1360,6 +1361,9 @@ export class ExchangeService implements 
ExchangeServiceInterface {
         const year = new Date().getFullYear();
 
         for (let i = year; i < year + 5; i++) {
+          const wireFee =
+            this.exchangeConfig.overrideWireFee ??
+            `${this.exchangeConfig.currency}:0.01`;
           await runCommand(
             this.globalState,
             "exchange-offline",
@@ -1373,7 +1377,7 @@ export class ExchangeService implements 
ExchangeServiceInterface {
               // Wire method
               accTargetType,
               // Wire fee
-              `${this.exchangeConfig.currency}:0.01`,
+              wireFee,
               // Closing fee
               `${this.exchangeConfig.currency}:0.01`,
               "upload",
diff --git 
a/packages/taler-harness/src/integrationtests/test-wallet-wirefees.ts 
b/packages/taler-harness/src/integrationtests/test-wallet-wirefees.ts
new file mode 100644
index 000000000..40880064b
--- /dev/null
+++ b/packages/taler-harness/src/integrationtests/test-wallet-wirefees.ts
@@ -0,0 +1,169 @@
+/*
+ This file is part of GNU Taler
+ (C) 2020 Taler Systems S.A.
+
+ GNU Taler is free software; you can redistribute it and/or modify it under the
+ terms of the GNU General Public License as published by the Free Software
+ Foundation; either version 3, or (at your option) any later version.
+
+ GNU Taler is distributed in the hope that it will be useful, but WITHOUT ANY
+ WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+ A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License along with
+ GNU Taler; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
+ */
+
+/**
+ * Imports.
+ */
+import {
+  Duration,
+  MerchantApiClient,
+  MerchantContractTerms,
+  PreparePayResultType,
+} from "@gnu-taler/taler-util";
+import { WalletApiOperation } from "@gnu-taler/taler-wallet-core";
+import { CoinConfig, defaultCoinConfig } from "../harness/denomStructures.js";
+import {
+  BankService,
+  ExchangeService,
+  GlobalTestState,
+  MerchantService,
+  generateRandomPayto,
+  setupDb,
+} from "../harness/harness.js";
+import {
+  createWalletDaemonWithClient,
+  withdrawViaBankV2,
+} from "../harness/helpers.js";
+
+/**
+ * Test payment where the exchange charges wire fees.
+ */
+export async function runWalletWirefeesTest(t: GlobalTestState) {
+  // Set up test environment
+
+  const db = await setupDb(t);
+
+  const bank = await BankService.create(t, {
+    allowRegistrations: true,
+    currency: "TESTKUDOS",
+    database: db.connStr,
+    httpPort: 8082,
+  });
+
+  const exchange = ExchangeService.create(t, {
+    name: "testexchange-1",
+    currency: "TESTKUDOS",
+    httpPort: 8081,
+    database: db.connStr,
+    // Ridiculously high wire fees!
+    overrideWireFee: "TESTKUDOS:5",
+  });
+
+  const merchant = await MerchantService.create(t, {
+    name: "testmerchant-1",
+    currency: "TESTKUDOS",
+    httpPort: 8083,
+    database: db.connStr,
+  });
+
+  const exchangeBankAccount = await bank.createExchangeAccount(
+    "myexchange",
+    "x",
+  );
+  await exchange.addBankAccount("1", exchangeBankAccount);
+
+  bank.setSuggestedExchange(exchange, exchangeBankAccount.accountPaytoUri);
+  await bank.start();
+
+  await bank.pingUntilAvailable();
+
+  const coinConfig: CoinConfig[] = defaultCoinConfig.map((x) => 
x("TESTKUDOS"));
+  exchange.addCoinConfigList(coinConfig);
+
+  await exchange.start();
+  await exchange.pingUntilAvailable();
+
+  merchant.addExchange(exchange);
+
+  await merchant.start();
+  await merchant.pingUntilAvailable();
+
+  await merchant.addInstanceWithWireAccount({
+    id: "default",
+    name: "Default Instance",
+    paytoUris: [generateRandomPayto("merchant-default")],
+    defaultWireTransferDelay: Duration.toTalerProtocolDuration(
+      Duration.fromSpec({ minutes: 1 }),
+    ),
+  });
+
+  await merchant.addInstanceWithWireAccount({
+    id: "minst1",
+    name: "minst1",
+    paytoUris: [generateRandomPayto("minst1")],
+    defaultWireTransferDelay: Duration.toTalerProtocolDuration(
+      Duration.fromSpec({ minutes: 1 }),
+    ),
+  });
+
+  const { walletClient, walletService } = await createWalletDaemonWithClient(
+    t,
+    { name: "wallet", persistent: true },
+  );
+
+  console.log("setup done!");
+
+  // Withdraw digital cash into the wallet.
+
+  await withdrawViaBankV2(t, {
+    walletClient,
+    bank,
+    exchange,
+    amount: "TESTKUDOS:20",
+  });
+
+  await walletClient.call(WalletApiOperation.TestingWaitTransactionsFinal, {});
+
+  const order = {
+    summary: "Buy me!",
+    amount: "TESTKUDOS:1",
+    fulfillment_url: "taler://fulfillment-success/thx",
+    //max_wire_fee: "TESTKUDOS:0.1",
+    max_fee: "TESTKUDOS:0.1",
+    wire_fee_amortization: 1,
+  } satisfies Partial<MerchantContractTerms>;
+
+  const merchantClient = new MerchantApiClient(merchant.makeInstanceBaseUrl());
+
+  const orderResp = await merchantClient.createOrder({
+    order,
+  });
+
+  let orderStatus = await merchantClient.queryPrivateOrderStatus({
+    orderId: orderResp.order_id,
+  });
+
+  t.assertTrue(orderStatus.order_status === "unpaid");
+
+  // Make wallet pay for the order
+
+  const preparePayResult = await walletClient.call(
+    WalletApiOperation.PreparePayForUri,
+    {
+      talerPayUri: orderStatus.taler_pay_uri,
+    },
+  );
+
+  t.assertTrue(
+    preparePayResult.status === PreparePayResultType.PaymentPossible,
+  );
+
+  console.log(`amountEffective: ${preparePayResult.amountEffective}`);
+
+  await walletClient.call(WalletApiOperation.TestingWaitTransactionsFinal, {});
+}
+
+runWalletWirefeesTest.suites = ["wallet"];
diff --git a/packages/taler-harness/src/integrationtests/testrunner.ts 
b/packages/taler-harness/src/integrationtests/testrunner.ts
index 0bfb245ab..a294b27f4 100644
--- a/packages/taler-harness/src/integrationtests/testrunner.ts
+++ b/packages/taler-harness/src/integrationtests/testrunner.ts
@@ -100,6 +100,7 @@ import { runWalletInsufficientBalanceTest } from 
"./test-wallet-insufficient-bal
 import { runWalletNotificationsTest } from "./test-wallet-notifications.js";
 import { runWalletObservabilityTest } from "./test-wallet-observability.js";
 import { runWalletRefreshTest } from "./test-wallet-refresh.js";
+import { runWalletWirefeesTest } from "./test-wallet-wirefees.js";
 import { runWallettestingTest } from "./test-wallettesting.js";
 import { runWithdrawalAbortBankTest } from "./test-withdrawal-abort-bank.js";
 import { runWithdrawalBankIntegratedTest } from 
"./test-withdrawal-bank-integrated.js";
@@ -206,6 +207,7 @@ const allTests: TestMainFunction[] = [
   runWalletDevExperimentsTest,
   runWalletBalanceZeroTest,
   runWalletInsufficientBalanceTest,
+  runWalletWirefeesTest,
 ];
 
 export interface TestRunSpec {

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.