[taler-exchange] branch master updated: more logging

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

The following commit(s) were added to refs/heads/master by this push:
     new bda16911 more logging
     new c52ca303 Merge branch 'master' of git+ssh://git.taler.net/exchange
bda16911 is described below

commit bda1691194a3413cb7576169d50ee83b13ac88e7
Author: Christian Grothoff <grothoff@gnunet.org>
AuthorDate: Sun Jan 14 16:45:07 2024 +0100

    more logging
---
 contrib/gana                 |  2 +-
 contrib/wallet-core          |  2 +-
 src/util/wallet_signatures.c | 31 +++++++++++++++++++++++++------
 3 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/contrib/gana b/contrib/gana
index 0ff4edfe..83680094 160000
--- a/contrib/gana
+++ b/contrib/gana
@@ -1 +1 @@
-Subproject commit 0ff4edfe76be77a59d4ebff5031feb50f3ba07d8
+Subproject commit 836800945d80db9c0160a10a84edc1a086339187
diff --git a/contrib/wallet-core b/contrib/wallet-core
index 496bfdc3..330edf87 160000
--- a/contrib/wallet-core
+++ b/contrib/wallet-core
@@ -1 +1 @@
-Subproject commit 496bfdc3aecbea61922bb2e0c281f5d35f934a3b
+Subproject commit 330edf879ab8f6fa4dbaf96de8ac84365c584e15
diff --git a/src/util/wallet_signatures.c b/src/util/wallet_signatures.c
index ebdb7eab..19d30c7e 100644
--- a/src/util/wallet_signatures.c
+++ b/src/util/wallet_signatures.c
@@ -201,16 +201,35 @@ TALER_wallet_deposit_verify (
                      amount);
   TALER_amount_hton (&dr.deposit_fee,
                      deposit_fee);
+  // FIXME: this logging leaks memory!
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-              "Validating deposit with hash %s, wallet timestamp %llu and 
refund deadline %llu by %s\n",
-              GNUNET_h2s (&h_contract_terms->hash),
+              "Validating deposit with hash %s, wallet timestamp %llu and 
refund deadline %llu by %s wdh %s over %s\n",
+              GNUNET_STRINGS_data_to_string_alloc (&h_contract_terms->hash,
+                                                   sizeof (h_contract_terms->
+                                                           hash)),
               (unsigned long long) wallet_timestamp.abs_time.abs_value_us,
               (unsigned long long) refund_deadline.abs_time.abs_value_us,
-              TALER_B2S (merchant_pub));
+              GNUNET_STRINGS_data_to_string_alloc (merchant_pub,
+                                                   sizeof (*merchant_pub)),
+              wallet_data_hash == NULL
+              ? "NULL"
+              : GNUNET_STRINGS_data_to_string_alloc (wallet_data_hash,
+                                                     sizeof 
(*wallet_data_hash)),
+              TALER_amount2s (amount));
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-              "Denomination is %s, wire target is %s\n",
-              GNUNET_h2s (&h_denom_pub->hash),
-              TALER_B2S (h_wire));
+              "Acom %s h_pol %s Denomination is %s, deposit fee %s, wire 
target is %s\n",
+              h_age_commitment == NULL
+              ? "NULL"
+              : GNUNET_STRINGS_data_to_string_alloc (h_age_commitment,
+                                                     sizeof 
(*h_age_commitment)),
+              h_policy == NULL
+              ? "NULL"
+              : GNUNET_STRINGS_data_to_string_alloc (h_policy,
+                                                     sizeof (*h_policy)),
+              GNUNET_STRINGS_data_to_string_alloc (&h_denom_pub->hash,
+                                                   sizeof (h_denom_pub->hash)),
+              TALER_amount2s (deposit_fee),
+              GNUNET_STRINGS_data_to_string_alloc (h_wire, sizeof (*h_wire)));
   if (GNUNET_OK !=
       GNUNET_CRYPTO_eddsa_verify (TALER_SIGNATURE_WALLET_COIN_DEPOSIT,
                                   &dr,

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.