[gnunet] branch master updated: GNSRECORD: Fix compiler warnings in tests

[gnunet]

This is an automated email from the git hooks/post-receive script.

martin-schanzenbach pushed a commit to branch master
in repository gnunet.

The following commit(s) were added to refs/heads/master by this push:
     new 72461ceb5 GNSRECORD: Fix compiler warnings in tests
72461ceb5 is described below

commit 72461ceb5f32a0ff8babbe7b10a95bb1fed8bfbf
Author: Martin Schanzenbach <schanzen@gnunet.org>
AuthorDate: Mon Nov 6 18:11:48 2023 +0100

    GNSRECORD: Fix compiler warnings in tests
---
 src/lib/gnsrecord/test_gnsrecord_block_expiration.c | 14 +++++++++-----
 src/lib/gnsrecord/test_gnsrecord_crypto.c           |  8 ++++++--
 src/lib/gnsrecord/test_gnsrecord_testvectors.c      |  3 ---
 3 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/src/lib/gnsrecord/test_gnsrecord_block_expiration.c 
b/src/lib/gnsrecord/test_gnsrecord_block_expiration.c
index 3ef02e631..bc580954e 100644
--- a/src/lib/gnsrecord/test_gnsrecord_block_expiration.c
+++ b/src/lib/gnsrecord/test_gnsrecord_block_expiration.c
@@ -49,6 +49,8 @@ run (void *cls, char *const *args, const char *cfgfile,
   struct GNUNET_GNSRECORD_Data rd[2];
   struct GNUNET_TIME_Absolute expiration_abs;
   struct GNUNET_TIME_Absolute expiration_abs_shadow;
+  char *tmp_data0;
+  char *tmp_data1;
 
   expiration_abs.abs_value_us = GNUNET_TIME_absolute_get ().abs_value_us
                                 + GNUNET_TIME_UNIT_SECONDS.rel_value_us;
@@ -59,14 +61,16 @@ run (void *cls, char *const *args, const char *cfgfile,
   rd[0].expiration_time = expiration_abs.abs_value_us;
   rd[0].record_type = TEST_RECORD_TYPE;
   rd[0].data_size = TEST_RECORD_DATALEN;
-  rd[0].data = GNUNET_malloc (TEST_RECORD_DATALEN);
+  tmp_data0 = GNUNET_malloc (TEST_RECORD_DATALEN);
+  rd[0].data = tmp_data0;
   rd[0].flags = GNUNET_GNSRECORD_RF_NONE;
   memset ((char *) rd[0].data, TEST_RECORD_DATA, TEST_RECORD_DATALEN);
 
   rd[1].expiration_time = expiration_abs.abs_value_us;
   rd[1].record_type = TEST_RECORD_TYPE;
   rd[1].data_size = TEST_RECORD_DATALEN;
-  rd[1].data = GNUNET_malloc (TEST_RECORD_DATALEN);
+  tmp_data1 = GNUNET_malloc (TEST_RECORD_DATALEN);
+  rd[1].data = tmp_data1;
   rd[1].flags = GNUNET_GNSRECORD_RF_NONE;
   memset ((char *) rd[1].data, TEST_RECORD_DATA, TEST_RECORD_DATALEN);
 
@@ -78,7 +82,7 @@ run (void *cls, char *const *args, const char *cfgfile,
   rd[1].expiration_time = expiration_abs_shadow.abs_value_us;
   rd[1].record_type = TEST_RECORD_TYPE;
   rd[1].data_size = TEST_RECORD_DATALEN;
-  GNUNET_free (rd[1].data);
+  GNUNET_free (tmp_data1);
   rd[1].data = GNUNET_malloc (TEST_RECORD_DATALEN);
   rd[1].flags = GNUNET_GNSRECORD_RF_SHADOW;
   memset ((char *) rd[1].data, TEST_RECORD_DATA, TEST_RECORD_DATALEN);
@@ -87,8 +91,8 @@ run (void *cls, char *const *args, const char *cfgfile,
                  GNUNET_GNSRECORD_record_get_expiration_time (2,
                                                               rd,
                                                              
GNUNET_TIME_UNIT_ZERO_ABS).abs_value_us);
-  GNUNET_free (rd[0].data);
-  GNUNET_free (rd[1].data);
+  GNUNET_free (tmp_data0);
+  GNUNET_free (tmp_data1);
   res = 0;
 }
 
diff --git a/src/lib/gnsrecord/test_gnsrecord_crypto.c 
b/src/lib/gnsrecord/test_gnsrecord_crypto.c
index ed5394e60..34f5f35e5 100644
--- a/src/lib/gnsrecord/test_gnsrecord_crypto.c
+++ b/src/lib/gnsrecord/test_gnsrecord_crypto.c
@@ -101,7 +101,7 @@ test_with_type (struct GNUNET_CRYPTO_PrivateKey *privkey)
   struct GNUNET_HashCode query_priv;
   struct GNUNET_HashCode query_block;
   struct GNUNET_TIME_Absolute expire = GNUNET_TIME_UNIT_FOREVER_ABS;
-
+  char* tmp_data;
 
   /* get public key */
   GNUNET_CRYPTO_key_get_public (privkey,
@@ -143,7 +143,11 @@ test_with_type (struct GNUNET_CRYPTO_PrivateKey *privkey)
                                                  s_name,
                                                  &rd_decrypt_cb,
                                                  NULL));
-  for (int i = 0; i < RECORDS; i++) GNUNET_free(s_rd[i].data);
+  for (int i = 0; i < RECORDS; i++)
+  {
+    tmp_data = (char*) s_rd[i].data;
+    GNUNET_free(tmp_data);
+  }
   GNUNET_free (s_rd);
   GNUNET_free (block);
 }
diff --git a/src/lib/gnsrecord/test_gnsrecord_testvectors.c 
b/src/lib/gnsrecord/test_gnsrecord_testvectors.c
index 04fd7f8bd..21a7a83b0 100644
--- a/src/lib/gnsrecord/test_gnsrecord_testvectors.c
+++ b/src/lib/gnsrecord/test_gnsrecord_testvectors.c
@@ -609,8 +609,6 @@ main ()
   struct GNUNET_HashCode query;
   struct GNUNET_HashCode expected_query;
   struct GNUNET_TIME_Absolute expire;
-  struct GNUNET_TIME_Relative exprel;
-  struct GNUNET_REVOCATION_PowP *pow;
   char label[128];
   char rdata[8096];
   char ztld[128];
@@ -706,6 +704,5 @@ main ()
       break;
     printf ("Good.\n");
   }
-finish:
   return res;
 }

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.