[gnunet] 02/03: TRANSPORT: Fix nullptr deref, removed newly introduced unused variable

[gnunet]

This is an automated email from the git hooks/post-receive script.

martin-schanzenbach pushed a commit to branch master
in repository gnunet.

commit a80ca417f330e983fe3b9512e84977ea3e4d4343
Author: Martin Schanzenbach <schanzen@gnunet.org>
AuthorDate: Sat Oct 28 00:19:52 2023 +0200

    TRANSPORT: Fix nullptr deref, removed newly introduced unused variable
---
 src/service/transport/gnunet-service-transport.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/src/service/transport/gnunet-service-transport.c 
b/src/service/transport/gnunet-service-transport.c
index 54d42fd51..0eded2d39 100644
--- a/src/service/transport/gnunet-service-transport.c
+++ b/src/service/transport/gnunet-service-transport.c
@@ -8655,7 +8655,6 @@ handle_hello_for_incoming (void *cls,
                            const char *emsg)
 {
   struct GNUNET_HELLO_Builder *builder;
-  struct GNUNET_PeerIdentity *pid;
 
   if (NULL != emsg)
   {
@@ -8667,12 +8666,10 @@ handle_hello_for_incoming (void *cls,
   if (0 == GNUNET_memcmp (peer, &GST_my_identity))
     return;
   builder = GNUNET_HELLO_builder_from_msg (hello);
-  pid = GNUNET_new (struct GNUNET_PeerIdentity);
   GNUNET_HELLO_builder_iterate (builder,
                                 (struct GNUNET_PeerIdentity *) peer,
                                 hello_for_incoming_cb,
                                 (struct GNUNET_PeerIdentity *) peer);
-  GNUNET_free (pid);
   GNUNET_HELLO_builder_free (builder);
 }
 
@@ -11293,7 +11290,6 @@ handle_hello_for_client (void *cls,
 {
   (void) cls;
   struct GNUNET_HELLO_Builder *builder;
-  struct GNUNET_PeerIdentity *pid;
 
   if (NULL != emsg)
   {
@@ -11305,12 +11301,10 @@ handle_hello_for_client (void *cls,
   if (0 == GNUNET_memcmp (peer, &GST_my_identity))
     return;
   builder = GNUNET_HELLO_builder_from_msg (hello);
-  pid = GNUNET_new (struct GNUNET_PeerIdentity);
   GNUNET_HELLO_builder_iterate (builder,
                                 (struct GNUNET_PeerIdentity *) peer,
                                 hello_for_client_cb,
-                                NULL);
-  GNUNET_free (pid);
+                                (struct GNUNET_PeerIdentity *) peer);
   GNUNET_HELLO_builder_free (builder);
 }
 

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.