[taler-wallet-core] branch master updated: move useNativeLogging to top-level

[gnunet]

This is an automated email from the git hooks/post-receive script.

dold pushed a commit to branch master
in repository wallet-core.

The following commit(s) were added to refs/heads/master by this push:
     new 2512665e9 move useNativeLogging to top-level
2512665e9 is described below

commit 2512665e9462690162a5bae5fab3337217943269
Author: Florian Dold <florian@dold.me>
AuthorDate: Mon Oct 23 18:15:41 2023 +0200

    move useNativeLogging to top-level
---
 packages/taler-wallet-core/src/host-impl.qtart.ts      | 4 ----
 packages/taler-wallet-core/src/wallet-api-types.ts     | 1 -
 packages/taler-wallet-core/src/wallet.ts               | 1 -
 packages/taler-wallet-embedded/src/wallet-qjs.ts       | 7 ++++++-
 packages/taler-wallet-webextension/src/platform/api.ts | 1 -
 5 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/packages/taler-wallet-core/src/host-impl.qtart.ts 
b/packages/taler-wallet-core/src/host-impl.qtart.ts
index a2fc75e9c..7917d6b0e 100644
--- a/packages/taler-wallet-core/src/host-impl.qtart.ts
+++ b/packages/taler-wallet-core/src/host-impl.qtart.ts
@@ -167,10 +167,6 @@ export async function createNativeWalletHost2(
 
   let dbResp: MakeDbResult;
 
-  if (args.config?.features?.useNativeLogging) {
-    enableNativeLogging();
-  }
-
   if (
     args.persistentStoragePath &&
     args.persistentStoragePath.endsWith(".json")
diff --git a/packages/taler-wallet-core/src/wallet-api-types.ts 
b/packages/taler-wallet-core/src/wallet-api-types.ts
index 3741105a4..375bc3eac 100644
--- a/packages/taler-wallet-core/src/wallet-api-types.ts
+++ b/packages/taler-wallet-core/src/wallet-api-types.ts
@@ -293,7 +293,6 @@ export interface WalletConfig {
    */
   features: {
     allowHttp: boolean;
-    useNativeLogging: boolean;
   };
 }
 
diff --git a/packages/taler-wallet-core/src/wallet.ts 
b/packages/taler-wallet-core/src/wallet.ts
index 79e4cf1a1..b3f8057a6 100644
--- a/packages/taler-wallet-core/src/wallet.ts
+++ b/packages/taler-wallet-core/src/wallet.ts
@@ -1744,7 +1744,6 @@ export class Wallet {
     },
     features: {
       allowHttp: false,
-      useNativeLogging: false,
     },
     testing: {
       preventThrottling: false,
diff --git a/packages/taler-wallet-embedded/src/wallet-qjs.ts 
b/packages/taler-wallet-embedded/src/wallet-qjs.ts
index 066062f23..1c0bca69a 100644
--- a/packages/taler-wallet-embedded/src/wallet-qjs.ts
+++ b/packages/taler-wallet-embedded/src/wallet-qjs.ts
@@ -15,7 +15,7 @@
  */
 
 /**
- * Entry-point for the wallet under qtart, the QuckJS-based GNU Taler runtime.
+ * Entry-point for the wallet under qtart, the QuickJS-based GNU Taler runtime.
  */
 
 /**
@@ -34,6 +34,7 @@ import {
   CoreApiMessageEnvelope,
   CoreApiResponse,
   CoreApiResponseSuccess,
+  enableNativeLogging,
   getErrorDetailFromException,
   j2s,
   Logger,
@@ -123,6 +124,10 @@ class NativeWalletMessageHandler {
         if (logLevel) {
           setGlobalLogLevelFromString(logLevel);
         }
+        const nativeLogging = args.useNativeLogging ?? false;
+        if (nativeLogging) {
+          enableNativeLogging();
+        }
         await reinit();
         return wrapSuccessResponse({
           ...initResponse,
diff --git a/packages/taler-wallet-webextension/src/platform/api.ts 
b/packages/taler-wallet-webextension/src/platform/api.ts
index 513191120..ae57b8faf 100644
--- a/packages/taler-wallet-webextension/src/platform/api.ts
+++ b/packages/taler-wallet-webextension/src/platform/api.ts
@@ -119,7 +119,6 @@ export const defaultSettings: Settings = {
   showJsonOnError: false,
   extendedAccountTypes: false,
   walletAllowHttp: false,
-  walletUseNativeLogging: false,
 };
 
 /**

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.