[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[taler-exchange] 02/06: minor clean ups
From: |
gnunet |
Subject: |
[taler-exchange] 02/06: minor clean ups |
Date: |
Tue, 17 Oct 2023 12:54:24 +0200 |
This is an automated email from the git hooks/post-receive script.
grothoff pushed a commit to branch master
in repository exchange.
commit a200dd5979d7b8ff869891c459c37b90e674b5ce
Author: Christian Grothoff <grothoff@gnunet.org>
AuthorDate: Tue Oct 17 12:14:46 2023 +0200
minor clean ups
---
src/exchangedb/0002-refresh_revealed_coins.sql | 9 ++++++---
src/exchangedb/0002-wad_in_entries.sql | 10 ----------
src/exchangedb/0002-wad_out_entries.sql | 6 ------
src/exchangedb/exchange_do_gc.sql | 14 +++++++-------
4 files changed, 13 insertions(+), 26 deletions(-)
diff --git a/src/exchangedb/0002-refresh_revealed_coins.sql
b/src/exchangedb/0002-refresh_revealed_coins.sql
index 9bf846e5..ad65c994 100644
--- a/src/exchangedb/0002-refresh_revealed_coins.sql
+++ b/src/exchangedb/0002-refresh_revealed_coins.sql
@@ -62,9 +62,12 @@ BEGIN
,table_name
,partition_suffix
);
- --
- -- FIXME: Add comment for link_sig
- --
+ PERFORM comment_partitioned_column(
+ 'Signature of type WALLET_COIN_LINK, proves exchange did not tamper with
the link data'
+ ,'link_sig'
+ ,table_name
+ ,partition_suffix
+ );
PERFORM comment_partitioned_column(
'envelope of the new coin to be signed'
,'coin_ev'
diff --git a/src/exchangedb/0002-wad_in_entries.sql
b/src/exchangedb/0002-wad_in_entries.sql
index 000f5c6c..3ef1f1b8 100644
--- a/src/exchangedb/0002-wad_in_entries.sql
+++ b/src/exchangedb/0002-wad_in_entries.sql
@@ -127,16 +127,6 @@ DECLARE
BEGIN
table_name = concat_ws('_', table_name, partition_suffix);
- -- FIXME: change to materialized index by reserve_pub!
- EXECUTE FORMAT (
- 'CREATE INDEX ' || table_name || '_reserve_pub '
- 'ON ' || table_name || ' '
- '(reserve_pub);'
- );
- EXECUTE FORMAT (
- 'COMMENT ON INDEX ' || table_name || '_reserve_pub '
- 'IS ' || quote_literal('needed in reserve history computation') || ';'
- );
EXECUTE FORMAT (
'ALTER TABLE ' || table_name ||
' ADD CONSTRAINT ' || table_name || '_wad_in_entry_serial_id_key'
diff --git a/src/exchangedb/0002-wad_out_entries.sql
b/src/exchangedb/0002-wad_out_entries.sql
index 8da0f04f..de921637 100644
--- a/src/exchangedb/0002-wad_out_entries.sql
+++ b/src/exchangedb/0002-wad_out_entries.sql
@@ -129,12 +129,6 @@ DECLARE
BEGIN
table_name = concat_ws('_', table_name, partition_suffix);
- -- FIXME: change to materialized index by reserve_pub!
- EXECUTE FORMAT (
- 'CREATE INDEX ' || table_name || '_by_reserve_pub '
- 'ON ' || table_name || ' '
- '(reserve_pub);'
- );
EXECUTE FORMAT (
'ALTER TABLE ' || table_name ||
' ADD CONSTRAINT ' || table_name || '_wad_out_entry_serial_id_key'
diff --git a/src/exchangedb/exchange_do_gc.sql
b/src/exchangedb/exchange_do_gc.sql
index 5758cb2d..140a4553 100644
--- a/src/exchangedb/exchange_do_gc.sql
+++ b/src/exchangedb/exchange_do_gc.sql
@@ -34,8 +34,8 @@ DELETE FROM exchange.prewire
DELETE FROM exchange.wire_fee
WHERE end_date < in_ancient_date;
--- TODO: use closing fee as threshold?
-DELETE FROM exchange.reserves
+-- FIXME: use closing fee as threshold?
+DELETE FROM reserves
WHERE gc_date < in_now
AND current_balance = (0, 0);
@@ -43,7 +43,7 @@ SELECT
reserve_out_serial_id
INTO
reserve_out_min
- FROM exchange.reserves_out
+ FROM reserves_out
ORDER BY reserve_out_serial_id ASC
LIMIT 1;
@@ -59,19 +59,19 @@ SELECT
ORDER BY reserve_uuid ASC
LIMIT 1;
-DELETE FROM exchange.reserves_out
+DELETE FROM reserves_out
WHERE reserve_uuid < reserve_uuid_min;
-- FIXME: this query will be horribly slow;
-- need to find another way to formulate it...
-DELETE FROM exchange.denominations
+DELETE FROM denominations
WHERE expire_legal < in_now
AND denominations_serial NOT IN
(SELECT DISTINCT denominations_serial
- FROM exchange.reserves_out)
+ FROM reserves_out)
AND denominations_serial NOT IN
(SELECT DISTINCT denominations_serial
- FROM exchange.known_coins
+ FROM known_coins
WHERE coin_pub IN
(SELECT DISTINCT coin_pub
FROM exchange.recoup))
--
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.
- [taler-exchange] branch master updated (c741c1fa -> 61a37f50), gnunet, 2023/10/17
- [taler-exchange] 05/06: use new 'was_decided' field instead of expensive subquery, gnunet, 2023/10/17
- [taler-exchange] 02/06: minor clean ups,
gnunet <=
- [taler-exchange] 03/06: add was_decided field and automatically set it via trigger, gnunet, 2023/10/17
- [taler-exchange] 06/06: avoid dumping accounts file everywhere, gnunet, 2023/10/17
- [taler-exchange] 01/06: kill another dead index, beautify SQL, gnunet, 2023/10/17
- [taler-exchange] 04/06: -remove silly comment, gnunet, 2023/10/17