[taler-merchant] branch master updated: -fix crash bug if order request was malformed

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository merchant.

The following commit(s) were added to refs/heads/master by this push:
     new 5252db85 -fix crash bug if order request was malformed
5252db85 is described below

commit 5252db8599a28b4e1c5385910204a63de76c27fc
Author: Christian Grothoff <grothoff@gnunet.org>
AuthorDate: Fri Aug 4 11:45:47 2023 +0200

    -fix crash bug if order request was malformed
---
 src/backend/taler-merchant-httpd_private-post-orders.c     |   1 +
 src/testing/test_merchant_api.c                            |   7 +++++++
 .../taler/exchange-secmod-cs/keys/coin_eur_1/1690392704    |   1 -
 .../taler/exchange-secmod-cs/keys/coin_eur_5/1690392704    | Bin 32 -> 0 bytes
 .../taler/exchange-secmod-cs/keys/coin_eur_ct_1/1690392704 |   1 -
 .../exchange-secmod-cs/keys/coin_eur_ct_10/1690392704      | Bin 32 -> 0 bytes
 6 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/backend/taler-merchant-httpd_private-post-orders.c 
b/src/backend/taler-merchant-httpd_private-post-orders.c
index 66cf71a5..c83baf1d 100644
--- a/src/backend/taler-merchant-httpd_private-post-orders.c
+++ b/src/backend/taler-merchant-httpd_private-post-orders.c
@@ -585,6 +585,7 @@ execute_order (struct OrderContext *oc)
       GNUNET_break_op (0);
       finalize_order2 (oc,
                        res);
+      return;
     }
   }
 
diff --git a/src/testing/test_merchant_api.c b/src/testing/test_merchant_api.c
index ac5af67c..3c3c004b 100644
--- a/src/testing/test_merchant_api.c
+++ b/src/testing/test_merchant_api.c
@@ -233,6 +233,13 @@ run (void *cls,
                                         EXCHANGE_URL,
                                         MHD_HTTP_NO_CONTENT,
                                         TALER_AML_NORMAL),
+    TALER_TESTING_cmd_merchant_post_orders_no_claim 
("create-proposal-bad-currency",
+                                                     merchant_url,
+                                                     MHD_HTTP_BAD_REQUEST,
+                                                     "4",
+                                                     GNUNET_TIME_UNIT_ZERO_TS,
+                                                     
GNUNET_TIME_UNIT_FOREVER_TS,
+                                                     "CHF:5.0"),
     TALER_TESTING_cmd_merchant_post_orders_no_claim ("create-proposal-4",
                                                      merchant_url,
                                                      MHD_HTTP_OK,
diff --git 
a/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_1/1690392704
 
b/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_1/1690392704
deleted file mode 100644
index 4840b98b..00000000
--- 
a/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_1/1690392704
+++ /dev/null
@@ -1 +0,0 @@
-�ZЁ�ڿ N
7Mt����4��G�jݞu
\ No newline at end of file
diff --git 
a/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_5/1690392704
 
b/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_5/1690392704
deleted file mode 100644
index 6b788b29..00000000
Binary files 
a/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_5/1690392704
 and /dev/null differ
diff --git 
a/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_ct_1/1690392704
 
b/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_ct_1/1690392704
deleted file mode 100644
index 5e2f4750..00000000
--- 
a/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_ct_1/1690392704
+++ /dev/null
@@ -1 +0,0 @@
-M�r;�Qd��1�~�������5|2�[
\ No newline at end of file
diff --git 
a/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_ct_10/1690392704
 
b/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_ct_10/1690392704
deleted file mode 100644
index 8aac305c..00000000
Binary files 
a/src/testing/test_merchant_api_home/taler/exchange-secmod-cs/keys/coin_eur_ct_10/1690392704
 and /dev/null differ

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.