[libmicrohttpd] 29/156: Remove double adding of MHD_HTTP_HEADER_CONNECTION response header

[gnunet]

This is an automated email from the git hooks/post-receive script.

karlson2k pushed a commit to tag v0.9.77
in repository libmicrohttpd.

commit 00085491b9c8562640c9dd3e8e395980a3fa944a
Author: Alexander Irion <alexander_irion@mentor.com>
AuthorDate: Wed Jun 15 12:34:49 2022 +0200

    Remove double adding of MHD_HTTP_HEADER_CONNECTION response header
    
    MHD_create_response_for_upgrade() already adds the 
MHD_HTTP_HEADER_CONNECTION response header, so
    the additional MHD_add_response_header is wrong.
    
    In our application it caused, that on a Apple iPad, the websocket was 
immediately closed by the
    browser(Safari, Chrome, Opera) after the protocol upgrade. Browsers on 
Linux, Android did not had this issue.
    
    Signed-off-by: Alexander Irion <alexander_irion@mentor.com>
---
 src/examples/websocket_chatserver_example.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/examples/websocket_chatserver_example.c 
b/src/examples/websocket_chatserver_example.c
index 0c39d5f0..54e62fde 100644
--- a/src/examples/websocket_chatserver_example.c
+++ b/src/examples/websocket_chatserver_example.c
@@ -2242,9 +2242,6 @@ access_handler (void *cls,
        * It requires the value of the Sec-WebSocket-Key header of the request.
        * See also: https://tools.ietf.org/html/rfc6455#section-4.2.2
        */
-      MHD_add_response_header (response,
-                               MHD_HTTP_HEADER_CONNECTION,
-                               "Upgrade");
       MHD_add_response_header (response,
                                MHD_HTTP_HEADER_UPGRADE,
                                "websocket");

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.