gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[taler-exchange] 01/02: add FIXME


From: gnunet
Subject: [taler-exchange] 01/02: add FIXME
Date: Sun, 16 Apr 2023 21:26:05 +0200

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

commit 10c779bbc6b50e7eaca813fa920f0c083c275b15
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Sun Apr 16 21:25:48 2023 +0200

    add FIXME
---
 src/kyclogic/plugin_kyclogic_oauth2.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/kyclogic/plugin_kyclogic_oauth2.c 
b/src/kyclogic/plugin_kyclogic_oauth2.c
index d4aaf449..228525e2 100644
--- a/src/kyclogic/plugin_kyclogic_oauth2.c
+++ b/src/kyclogic/plugin_kyclogic_oauth2.c
@@ -514,6 +514,11 @@ initiate_task (void *cls)
                    pd->client_id,
                    redirect_uri_encoded);
   GNUNET_free (redirect_uri_encoded);
+  /* FIXME-API: why do we *redirect* the client here,
+     instead of making the HTTP request *ourselves*
+     and forwarding the response? This prevents us
+     from using authentication on initiation,
+     (which is desirable for challenger!) */
   ih->cb (ih->cb_cls,
           TALER_EC_NONE,
           url,

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]