gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[taler-taler-android] branch master updated: [wallet] add a FIXME for an


From: gnunet
Subject: [taler-taler-android] branch master updated: [wallet] add a FIXME for an app got killed issue
Date: Thu, 13 Apr 2023 21:07:24 +0200

This is an automated email from the git hooks/post-receive script.

torsten-grote pushed a commit to branch master
in repository taler-android.

The following commit(s) were added to refs/heads/master by this push:
     new 6ca4795  [wallet] add a FIXME for an app got killed issue
6ca4795 is described below

commit 6ca47955402d8557b00b0d334b3a60ecd071368b
Author: Torsten Grote <t@grobox.de>
AuthorDate: Thu Apr 13 16:07:14 2023 -0300

    [wallet] add a FIXME for an app got killed issue
---
 wallet/src/main/java/net/taler/wallet/exchanges/ExchangeListFragment.kt | 2 +-
 .../src/main/java/net/taler/wallet/transactions/TransactionManager.kt   | 2 ++
 .../src/main/java/net/taler/wallet/transactions/TransactionsFragment.kt | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git 
a/wallet/src/main/java/net/taler/wallet/exchanges/ExchangeListFragment.kt 
b/wallet/src/main/java/net/taler/wallet/exchanges/ExchangeListFragment.kt
index 44c98c1..21e31f4 100644
--- a/wallet/src/main/java/net/taler/wallet/exchanges/ExchangeListFragment.kt
+++ b/wallet/src/main/java/net/taler/wallet/exchanges/ExchangeListFragment.kt
@@ -99,7 +99,7 @@ open class ExchangeListFragment : Fragment(), 
ExchangeClickListener {
 
     override fun onPeerReceive(item: ExchangeItem) {
         transactionManager.selectedCurrency = item.currency
-        findNavController().navigate(R.id.receiveFunds)
+        findNavController().navigate(R.id.action_global_receiveFunds)
     }
 
 }
diff --git 
a/wallet/src/main/java/net/taler/wallet/transactions/TransactionManager.kt 
b/wallet/src/main/java/net/taler/wallet/transactions/TransactionManager.kt
index f6f25cc..fcc7787 100644
--- a/wallet/src/main/java/net/taler/wallet/transactions/TransactionManager.kt
+++ b/wallet/src/main/java/net/taler/wallet/transactions/TransactionManager.kt
@@ -41,6 +41,8 @@ class TransactionManager(
     private val mProgress = MutableLiveData<Boolean>()
     val progress: LiveData<Boolean> = mProgress
 
+    // FIXME if the app gets killed, this will not be restored and thus be 
unexpected null
+    //  we should keep this in a savable, maybe using Hilt and 
SavedStateViewModel
     var selectedCurrency: String? = null
 
     val searchQuery = MutableLiveData<String>(null)
diff --git 
a/wallet/src/main/java/net/taler/wallet/transactions/TransactionsFragment.kt 
b/wallet/src/main/java/net/taler/wallet/transactions/TransactionsFragment.kt
index f2a74e2..5dff704 100644
--- a/wallet/src/main/java/net/taler/wallet/transactions/TransactionsFragment.kt
+++ b/wallet/src/main/java/net/taler/wallet/transactions/TransactionsFragment.kt
@@ -123,7 +123,7 @@ class TransactionsFragment : Fragment(), 
OnTransactionClickListener, ActionMode.
             findNavController().navigate(R.id.sendFunds)
         }
         ui.receiveButton.setOnClickListener {
-            findNavController().navigate(R.id.receiveFunds)
+            findNavController().navigate(R.id.action_global_receiveFunds)
         }
         ui.mainFab.setOnClickListener {
             model.scanCode()

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]