[taler-exchange] branch master updated: -investigate FIXME

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

The following commit(s) were added to refs/heads/master by this push:
     new 7ebdac0a -investigate FIXME
7ebdac0a is described below

commit 7ebdac0a8bccd6842382376653403cd3d82ffab0
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Mon May 2 20:51:34 2022 +0200

    -investigate FIXME
---
 src/exchangedb/plugin_exchangedb_postgres.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/exchangedb/plugin_exchangedb_postgres.c 
b/src/exchangedb/plugin_exchangedb_postgres.c
index 644b9f5c..aa4066e6 100644
--- a/src/exchangedb/plugin_exchangedb_postgres.c
+++ b/src/exchangedb/plugin_exchangedb_postgres.c
@@ -2198,10 +2198,11 @@ prepare_statements (struct PostgresClosure *pg)
       ",amount_frac"
       ",recoup_timestamp"
       ",recoup_uuid"
-      " FROM recoup"
-      // FIXME: suboptimal sub-query here: crosses shards!
-      // MAYBE: replace reserve_out_serial_id with
-      // reserve_pub and use new reserve_out_by_reserve table?
+      " FROM recoup rcp"
+      /* NOTE: suboptimal JOIN follows: crosses shards!
+         Could theoretically be improved via a materialized
+         index. But likely not worth it (query is rare and
+         number of reserve shards might be limited) */
       " JOIN reserves_out ro"
       "   USING (reserve_out_serial_id)"
       " JOIN reserves"

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.