gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[taler-docs] branch master updated: -comments for Florian


From: gnunet
Subject: [taler-docs] branch master updated: -comments for Florian
Date: Fri, 13 Aug 2021 23:14:25 +0200

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository docs.

The following commit(s) were added to refs/heads/master by this push:
     new 2268e4b  -comments for Florian
2268e4b is described below

commit 2268e4b9c7de07f753dc817616e730766eacffe9
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Fri Aug 13 23:14:23 2021 +0200

    -comments for Florian
---
 merchant-spec/public-orders-get.ts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/merchant-spec/public-orders-get.ts 
b/merchant-spec/public-orders-get.ts
index 130f53f..ef9eee3 100644
--- a/merchant-spec/public-orders-get.ts
+++ b/merchant-spec/public-orders-get.ts
@@ -63,6 +63,11 @@ function handlePublicOrdersGet(mos: MerchantOrderStore, req: 
Req): Resp {
     // Client is trying to get the order status of a claimed,
     // unpaid order.  However, the client is not showing authentication.
     //
+    // CG-FIXME: Eh, nothing here suggests the order is _claimed_.
+    // The branch above is wrong, as an unclaimed order without
+    // requireClaimToken must not end up here! So I think
+    // we here need authMissing && !authOk in the branch above!
+    //
     // This can happen when the fulfillment URL includes the order ID,
     // and the storefront redirects the user to the backend QR code
     // page, because the order is not paid under the current session.

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]