[gnurl] 336/411: cmake: don't pass -fvisibility=hidden to clang-cl on Windows

[gnunet]

This is an automated email from the git hooks/post-receive script.

nikita pushed a commit to branch master
in repository gnurl.

commit fd5f35ef0b5635fae2bc39335d6339c96b843b33
Author: Tobias Hieta <tobias@plex.tv>
AuthorDate: Tue Nov 10 10:30:29 2020 +0100

    cmake: don't pass -fvisibility=hidden to clang-cl on Windows
    
    When using clang-cl on windows -fvisibility=hidden is not an known
    argument. Instead it behaves exactly like MSVC in this case. So let's
    make sure we take that path.
    
    In CMake clang-cl sets both CMAKE_C_COMPILER_ID=clang and MSVC get's
    defined since clang-cl is basically a MSVC emulator. So guarding like we
    do in this patch seems logical.
    
    Reviewed-by: Jakub Zakrzewski
    Closes #6194
---
 CMake/CurlSymbolHiding.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMake/CurlSymbolHiding.cmake b/CMake/CurlSymbolHiding.cmake
index f8500a845..e99ea6f64 100644
--- a/CMake/CurlSymbolHiding.cmake
+++ b/CMake/CurlSymbolHiding.cmake
@@ -27,7 +27,7 @@ mark_as_advanced(CURL_HIDDEN_SYMBOLS)
 if(CURL_HIDDEN_SYMBOLS)
   set(SUPPORTS_SYMBOL_HIDING FALSE)
 
-  if(CMAKE_C_COMPILER_ID MATCHES "Clang")
+  if(CMAKE_C_COMPILER_ID MATCHES "Clang" AND NOT MSVC)
     set(SUPPORTS_SYMBOL_HIDING TRUE)
     set(_SYMBOL_EXTERN "__attribute__ ((__visibility__ (\"default\")))")
     set(_CFLAG_SYMBOLS_HIDE "-fvisibility=hidden")

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.