[taler-anastasis] branch master updated: clarify

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository anastasis.

The following commit(s) were added to refs/heads/master by this push:
     new 146f081  clarify
146f081 is described below

commit 146f08155ad3000de30b8d4655fdd93b357445da
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Tue Oct 20 10:15:31 2020 +0200

    clarify
---
 src/backend/anastasis_authorization_plugin_file.c | 10 ++++++----
 src/include/anastasis_authorization_plugin.h      | 11 ++++++++---
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/backend/anastasis_authorization_plugin_file.c 
b/src/backend/anastasis_authorization_plugin_file.c
index 06f7242..127fc10 100644
--- a/src/backend/anastasis_authorization_plugin_file.c
+++ b/src/backend/anastasis_authorization_plugin_file.c
@@ -62,7 +62,7 @@ struct ANASTASIS_AUTHORIZATION_State
  *         #GNUNET_NO if @a data is invalid and a reply was successfully 
queued on @a connection
  *         #GNUNET_SYSERR if @a data invalid but we failed to queue a reply on 
@a connection
  */
-enum GNUNET_GenericReturnValue
+static enum GNUNET_GenericReturnValue
 file_validate (void *cls,
                struct MHD_Connection *connection,
                const char *data,
@@ -88,7 +88,7 @@ file_validate (void *cls,
  * @param data input to validate (i.e. is it a valid phone number, etc.)
  * @return state to track progress on the authorization operation, NULL on 
failure
  */
-struct ANASTASIS_AUTHORIZATION_State *
+static struct ANASTASIS_AUTHORIZATION_State *
 file_start (void *cls,
             const struct ANASTASIS_CRYPTO_TruthPublicKeyP *truth_public_key,
             uint64_t code,
@@ -96,6 +96,7 @@ file_start (void *cls,
             size_t data_length)
 {
   struct ANASTASIS_AUTHORIZATION_State *as;
+
   as = GNUNET_new (struct ANASTASIS_AUTHORIZATION_State);
   as->cls = cls;
   as->truth_public_key = truth_public_key;
@@ -114,7 +115,7 @@ file_start (void *cls,
  * @param connection HTTP client request (for queuing response, such as 
redirection to video portal)
  * @return state of the request
  */
-enum ANASTASIS_AUTHORIZATION_Result
+static enum ANASTASIS_AUTHORIZATION_Result
 file_process (struct ANASTASIS_AUTHORIZATION_State *as,
               struct MHD_Connection *connection)
 {
@@ -138,7 +139,7 @@ file_process (struct ANASTASIS_AUTHORIZATION_State *as,
  *
  * @param as state to clean up
  */
-void
+static void
 file_cleanup (struct ANASTASIS_AUTHORIZATION_State *as)
 {
   GNUNET_free (as);
@@ -156,6 +157,7 @@ libanastasis_plugin_authorization_file_init (void *cls)
 {
   struct GNUNET_CONFIGURATION_Handle *cfg = cls;
   struct ANASTASIS_AuthorizationPlugin *plugin;
+
   plugin = GNUNET_new (struct ANASTASIS_AuthorizationPlugin);
   plugin->validate = &file_validate;
   plugin->start = &file_start;
diff --git a/src/include/anastasis_authorization_plugin.h 
b/src/include/anastasis_authorization_plugin.h
index ab74d1b..852c308 100644
--- a/src/include/anastasis_authorization_plugin.h
+++ b/src/include/anastasis_authorization_plugin.h
@@ -98,9 +98,12 @@ struct ANASTASIS_AuthorizationPlugin
               const char *data,
               size_t data_length);
 
+
   /**
    * Begin issuing authentication challenge to user based on @a data.
-   * I.e. start to send SMS or e-mail or launch video identification.
+   * I.e. start to send SMS or e-mail or launch video identification,
+   * or at least setup our authorization state (actual processing
+   * may also be startedin the @e process function).
    *
    * @param cls closure
    * @param truth_public_key Identifier of the challenge, to be (if possible) 
included in the
@@ -119,8 +122,10 @@ struct ANASTASIS_AuthorizationPlugin
 
 
   /**
-   * Begin issuing authentication challenge to user based on @a data.
-   * I.e. start to send SMS or e-mail or launch video identification.
+   * Continue issuing authentication challenge to user based on @a data.
+   * I.e. check if the transmission of the challenge via SMS or e-mail
+   * has completed and/or manipulate @a connection to redirect the client
+   * to a video identification site.
    *
    * @param as authorization state
    * @param connection HTTP client request (for queuing response, such as 
redirection to video portal)

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.