[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnurl] 31/264: tool_operate: fix add_parallel_transfers when more are i
From: |
gnunet |
Subject: |
[gnurl] 31/264: tool_operate: fix add_parallel_transfers when more are in queue |
Date: |
Thu, 30 Apr 2020 16:05:34 +0200 |
This is an automated email from the git hooks/post-receive script.
nikita pushed a commit to branch master
in repository gnurl.
commit 95c36fff75883ace6e8e7a89b94362de2dd1857f
Author: Daniel Stenberg <address@hidden>
AuthorDate: Mon Mar 16 09:33:27 2020 +0100
tool_operate: fix add_parallel_transfers when more are in queue
Trying to return early from the function if no new transfers were added
would break the "morep" argument and cause issues. This could lead to
zero content "transfers" (within quotes since they would never be
started) when parallel-max was reduced.
Reported-by: Gavin Wong
Analyzed-by: Jay Satiro
Fixes #4937
Closes #5112
---
src/tool_operate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tool_operate.c b/src/tool_operate.c
index 4b3caa80c..ab06b71c5 100644
--- a/src/tool_operate.c
+++ b/src/tool_operate.c
@@ -2055,7 +2055,7 @@ static CURLcode add_parallel_transfers(struct
GlobalConfig *global,
*addedp = FALSE;
*morep = FALSE;
result = create_transfer(global, share, addedp);
- if(result || !*addedp)
+ if(result)
return result;
for(per = transfers; per && (all_added < global->parallel_max);
per = per->next) {
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [gnurl] 17/264: ci/tests: fix and align setting TFLAGS for make test-nonflaky, (continued)
- [gnurl] 17/264: ci/tests: fix and align setting TFLAGS for make test-nonflaky, gnunet, 2020/04/30
- [gnurl] 14/264: Makefile.m32: Improve windres parameter compatibility, gnunet, 2020/04/30
- [gnurl] 19/264: select: move duplicate select preparation code into Curl_select, gnunet, 2020/04/30
- [gnurl] 24/264: tests/README: add note about manually installing python-impacket, gnunet, 2020/04/30
- [gnurl] 23/264: transfer: cap retries of "dead connections" to 5, gnunet, 2020/04/30
- [gnurl] 25/264: ci/tests: install impacket for SMB tests on FreeBSD using CirrusCI, gnunet, 2020/04/30
- [gnurl] 20/264: select: fix 'pending_ms' is assigned a value that is never used, gnunet, 2020/04/30
- [gnurl] 27/264: gskit: use our internal select wrapper for portability, gnunet, 2020/04/30
- [gnurl] 29/264: ci/tests: fix Azure Pipelines not running for pull requests, gnunet, 2020/04/30
- [gnurl] 28/264: gskit: update the copyright year range, gnunet, 2020/04/30
- [gnurl] 31/264: tool_operate: fix add_parallel_transfers when more are in queue,
gnunet <=
- [gnurl] 38/264: writeout_json: add missing comma to fix the HTTP version, gnunet, 2020/04/30
- [gnurl] 18/264: connect: happy eyeballs cleanup, gnunet, 2020/04/30
- [gnurl] 26/264: tests: fix verification of stdout in test 1452 due to newline, gnunet, 2020/04/30
- [gnurl] 35/264: CI: stop ignoring 323, it is disabled, gnunet, 2020/04/30
- [gnurl] 36/264: writeout: support to generate JSON output, gnunet, 2020/04/30
- [gnurl] 32/264: cmake: add support for building with wolfSSL, gnunet, 2020/04/30
- [gnurl] 41/264: schannel: add "best effort" revocation check option, gnunet, 2020/04/30
- [gnurl] 12/264: docs: add warnings about FILE: URLs on Windows, gnunet, 2020/04/30
- [gnurl] 47/264: tests: make Python-based servers compatible with Python 2 and 3, gnunet, 2020/04/30
- [gnurl] 45/264: RELEASE-NOTES: synced, gnunet, 2020/04/30