[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnurl] 198/222: HTTP3: fix invalid use of sendto for connected UDP sock
From: |
gnunet |
Subject: |
[gnurl] 198/222: HTTP3: fix invalid use of sendto for connected UDP socket |
Date: |
Thu, 07 Nov 2019 00:11:34 +0100 |
This is an automated email from the git hooks/post-receive script.
ng0 pushed a commit to branch master
in repository gnurl.
commit 9f5b26d23fe0d666debc4526abe7a078601e20dc
Author: Javier Blazquez <address@hidden>
AuthorDate: Sun Oct 27 17:16:24 2019 -0700
HTTP3: fix invalid use of sendto for connected UDP socket
On macOS/BSD, trying to call sendto on a connected UDP socket fails
with a EISCONN error. Because the singleipconnect has already called
connect on the socket when we're trying to use it for QUIC transfers
we need to use plain send instead.
Fixes #4529
Closes https://github.com/curl/curl/pull/4533
---
lib/vquic/ngtcp2.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/vquic/ngtcp2.c b/lib/vquic/ngtcp2.c
index 864751101..c0f9b16e3 100644
--- a/lib/vquic/ngtcp2.c
+++ b/lib/vquic/ngtcp2.c
@@ -1544,9 +1544,7 @@ static CURLcode ng_flush_egress(struct connectdata *conn,
int sockfd,
}
memcpy(&remote_addr, ps.path.remote.addr, ps.path.remote.addrlen);
- while((sent = sendto(sockfd, out, outlen, 0,
- (struct sockaddr *)&remote_addr,
- (socklen_t)ps.path.remote.addrlen)) == -1 &&
+ while((sent = send(sockfd, out, outlen, 0)) == -1 &&
SOCKERRNO == EINTR)
;
@@ -1556,7 +1554,7 @@ static CURLcode ng_flush_egress(struct connectdata *conn,
int sockfd,
break;
}
else {
- failf(conn->data, "sendto() returned %zd (errno %d)\n", sent,
+ failf(conn->data, "send() returned %zd (errno %d)\n", sent,
SOCKERRNO);
return CURLE_SEND_ERROR;
}
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [gnurl] 203/222: url: make Curl_close() NULLify the pointer too, (continued)
- [gnurl] 203/222: url: make Curl_close() NULLify the pointer too, gnunet, 2019/11/06
- [gnurl] 205/222: gtls: make gnutls_bye() not wait for response on shutdown, gnunet, 2019/11/06
- [gnurl] 207/222: mbedtls: add error message for cert validity starting in the future, gnunet, 2019/11/06
- [gnurl] 210/222: configure: only say ipv6 enabled when the variable is set, gnunet, 2019/11/06
- [gnurl] 216/222: awk, gnunet, 2019/11/06
- [gnurl] 161/222: asyn-thread: make use of Curl_socketpair() where available, gnunet, 2019/11/06
- [gnurl] 174/222: url: normalize CURLINFO_EFFECTIVE_URL, gnunet, 2019/11/06
- [gnurl] 167/222: KNOWN_BUGS: remove "CURLFORM_CONTENTLEN in an array", gnunet, 2019/11/06
- [gnurl] 190/222: conn-reuse: requests wanting NTLM can reuse non-NTLM connections, gnunet, 2019/11/06
- [gnurl] 185/222: runtests: get textaware info from curl instead of perl, gnunet, 2019/11/06
- [gnurl] 198/222: HTTP3: fix invalid use of sendto for connected UDP socket,
gnunet <=
- [gnurl] 169/222: connect: silence sign-compare warning, gnunet, 2019/11/06
- [gnurl] 201/222: url: Curl_free_request_state() should also free doh handles, gnunet, 2019/11/06
- [gnurl] 214/222: awk scripts., gnunet, 2019/11/06
- [gnurl] 217/222: awk., gnunet, 2019/11/06
- [gnurl] 219/222: include., gnunet, 2019/11/06
- [gnurl] 212/222: RELEASE-NOTES: synced, gnunet, 2019/11/06
- [gnurl] 222/222: minor, gnunet, 2019/11/06
- [gnurl] 215/222: awk, gnunet, 2019/11/06
- [gnurl] 175/222: tool_operate: Fix retry sleep time shown to user when Retry-After, gnunet, 2019/11/06
- [gnurl] 186/222: tests: add `connect to non-listen` keywords, gnunet, 2019/11/06