[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnurl] 55/222: libssh2: part of conditional expression is always true:
From: |
gnunet |
Subject: |
[gnurl] 55/222: libssh2: part of conditional expression is always true: !result |
Date: |
Thu, 07 Nov 2019 00:09:11 +0100 |
This is an automated email from the git hooks/post-receive script.
ng0 pushed a commit to branch master
in repository gnurl.
commit 7d5524500d63e892743071213062f8e46a0fee3f
Author: Daniel Stenberg <address@hidden>
AuthorDate: Thu Sep 19 10:25:15 2019 +0200
libssh2: part of conditional expression is always true: !result
Fixes warning detected by PVS-Studio
Fixes #4374
---
lib/vssh/libssh2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vssh/libssh2.c b/lib/vssh/libssh2.c
index 2b25a514f..6a6793aa3 100644
--- a/lib/vssh/libssh2.c
+++ b/lib/vssh/libssh2.c
@@ -2811,7 +2811,7 @@ static CURLcode ssh_block_statemach(struct connectdata
*conn,
}
#ifdef HAVE_LIBSSH2_SESSION_BLOCK_DIRECTION
- if(!result && block) {
+ if(block) {
int dir = libssh2_session_block_directions(sshc->ssh_session);
curl_socket_t sock = conn->sock[FIRSTSOCKET];
curl_socket_t fd_read = CURL_SOCKET_BAD;
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [gnurl] 33/222: RELEASE-NOTES: synced, (continued)
- [gnurl] 33/222: RELEASE-NOTES: synced, gnunet, 2019/11/06
- [gnurl] 31/222: README: add OSS-Fuzz badge [skip ci], gnunet, 2019/11/06
- [gnurl] 40/222: ftp: Expression 'ftpc->wait_data_conn' is always false, gnunet, 2019/11/06
- [gnurl] 45/222: netrc: part of conditional expression is always true: !done, gnunet, 2019/11/06
- [gnurl] 35/222: urlapi: CURLU_NO_AUTHORITY allows empty authority/host part, gnunet, 2019/11/06
- [gnurl] 38/222: ftp: part of conditional expression is always true: !result, gnunet, 2019/11/06
- [gnurl] 37/222: http: fix Expression 'http->postdata' is always false, gnunet, 2019/11/06
- [gnurl] 41/222: ftp: the conditional expression is always true, gnunet, 2019/11/06
- [gnurl] 54/222: urlapi: Expression 'storep' is always true, gnunet, 2019/11/06
- [gnurl] 47/222: multi: value '2L' is assigned to a boolean, gnunet, 2019/11/06
- [gnurl] 55/222: libssh2: part of conditional expression is always true: !result,
gnunet <=
- [gnurl] 53/222: urlapi: 'scheme' is always true, gnunet, 2019/11/06
- [gnurl] 58/222: tool_operate: removed unused variable 'done', gnunet, 2019/11/06
- [gnurl] 59/222: travis: use go master, gnunet, 2019/11/06
- [gnurl] 61/222: ngtcp2: compile with latest ngtcp2 + nghttp3 draft-23, gnunet, 2019/11/06
- [gnurl] 49/222: http_proxy: part of conditional expression is always true: !error, gnunet, 2019/11/06
- [gnurl] 60/222: THANKS-filter: deal with my typos 'Jat' => 'Jay', gnunet, 2019/11/06
- [gnurl] 64/222: FTP: FTPFILE_NOCWD: avoid redundant CWDs, gnunet, 2019/11/06
- [gnurl] 68/222: altsvc: both backends run h3-23 now, gnunet, 2019/11/06
- [gnurl] 48/222: imap: merged two case-branches performing the same action, gnunet, 2019/11/06
- [gnurl] 50/222: mime: make Curl_mime_duppart() assert if called without valid dst, gnunet, 2019/11/06