[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnurl] 36/222: doh: avoid truncating DNS QTYPE to lower octet
From: |
gnunet |
Subject: |
[gnurl] 36/222: doh: avoid truncating DNS QTYPE to lower octet |
Date: |
Thu, 07 Nov 2019 00:08:52 +0100 |
This is an automated email from the git hooks/post-receive script.
ng0 pushed a commit to branch master
in repository gnurl.
commit 0d59addff6af9d32b7b92b61ebd74915c2ff13e8
Author: Niall O'Reilly <address@hidden>
AuthorDate: Thu Sep 19 14:38:14 2019 +0100
doh: avoid truncating DNS QTYPE to lower octet
Closes #4381
---
lib/doh.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/doh.c b/lib/doh.c
index e97e4fe7a..5a76d6d87 100644
--- a/lib/doh.c
+++ b/lib/doh.c
@@ -135,8 +135,10 @@ UNITTEST DOHcode doh_encode(const char *host,
}
} while(1);
- *dnsp++ = '\0'; /* upper 8 bit TYPE */
- *dnsp++ = (unsigned char)dnstype;
+ /* There are assigned TYPE codes beyond 255: use range [1..65535] */
+ *dnsp++ = (unsigned char)(255 & (dnstype>>8)); /* upper 8 bit TYPE */
+ *dnsp++ = (unsigned char)(255 & dnstype); /* lower 8 bit TYPE */
+
*dnsp++ = '\0'; /* upper 8 bit CLASS */
*dnsp++ = DNS_CLASS_IN; /* IN - "the Internet" */
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [gnurl] 21/222: openssl: fix warning with boringssl and SSL_CTX_set_min_proto_version, (continued)
- [gnurl] 21/222: openssl: fix warning with boringssl and SSL_CTX_set_min_proto_version, gnunet, 2019/11/06
- [gnurl] 16/222: CI: inintial github action job, gnunet, 2019/11/06
- [gnurl] 20/222: doh: fix undefined behaviour and open up for gcc and clang optimization, gnunet, 2019/11/06
- [gnurl] 26/222: http2: relax verification of :authority in push promise requests, gnunet, 2019/11/06
- [gnurl] 27/222: url: cleanup dangling DOH request headers too, gnunet, 2019/11/06
- [gnurl] 28/222: mime: when disabled, avoid C99 macro, gnunet, 2019/11/06
- [gnurl] 32/222: url: only reuse TLS connections with matching pinning, gnunet, 2019/11/06
- [gnurl] 39/222: ftp: Expression 'ftpc->wait_data_conn' is always true, gnunet, 2019/11/06
- [gnurl] 46/222: easy: part of conditional expression is always true: !result, gnunet, 2019/11/06
- [gnurl] 30/222: http: merge two "case" statements, gnunet, 2019/11/06
- [gnurl] 36/222: doh: avoid truncating DNS QTYPE to lower octet,
gnunet <=
- [gnurl] 29/222: FTP: remove trailing slash from path for LIST/MLSD, gnunet, 2019/11/06
- [gnurl] 43/222: url: remove dead code, gnunet, 2019/11/06
- [gnurl] 42/222: url: part of expression is always true: (bundle->multiuse == 0), gnunet, 2019/11/06
- [gnurl] 44/222: version: Expression 'left > 1' is always true, gnunet, 2019/11/06
- [gnurl] 34/222: version: next release will be 7.67.0, gnunet, 2019/11/06
- [gnurl] 33/222: RELEASE-NOTES: synced, gnunet, 2019/11/06
- [gnurl] 31/222: README: add OSS-Fuzz badge [skip ci], gnunet, 2019/11/06
- [gnurl] 40/222: ftp: Expression 'ftpc->wait_data_conn' is always false, gnunet, 2019/11/06
- [gnurl] 45/222: netrc: part of conditional expression is always true: !done, gnunet, 2019/11/06
- [gnurl] 35/222: urlapi: CURLU_NO_AUTHORITY allows empty authority/host part, gnunet, 2019/11/06