[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[GNUnet-SVN] [libmicrohttpd] 151/154: mhd_send.c: for now, let EINVAL an
From: |
gnunet |
Subject: |
[GNUnet-SVN] [libmicrohttpd] 151/154: mhd_send.c: for now, let EINVAL and EBADF fail hard. |
Date: |
Mon, 19 Aug 2019 10:17:43 +0200 |
This is an automated email from the git hooks/post-receive script.
ng0 pushed a commit to branch master
in repository libmicrohttpd.
commit c51869af5a5f1b76cce745afaf9c75ac9a502ee0
Author: ng0 <address@hidden>
AuthorDate: Sun Aug 18 11:19:40 2019 +0000
mhd_send.c: for now, let EINVAL and EBADF fail hard.
---
src/microhttpd/mhd_send.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/microhttpd/mhd_send.c b/src/microhttpd/mhd_send.c
index b3fb25da..862bd6e9 100644
--- a/src/microhttpd/mhd_send.c
+++ b/src/microhttpd/mhd_send.c
@@ -76,6 +76,7 @@ pre_cork_setsockopt (struct MHD_Connection *connection,
break;
case EBADF:
/* FIXME: should we die hard here? */
+ return MHD_ERR_BADF_; /* Fail hard */
break;
case EINVAL:
/* FIXME: optlen invalid, should at least log this, maybe die */
@@ -84,6 +85,7 @@ pre_cork_setsockopt (struct MHD_Connection *connection,
_("optlen invalid: %s\n"),
MHD_socket_last_strerr_());
#endif
+ return MHD_ERR_INVAL_; /* Fail hard */
break;
case EFAULT:
/* wopsie, should at leats log this, FIXME: maybe die */
@@ -162,6 +164,7 @@ post_cork_setsockopt (struct MHD_Connection *connection,
break;
case EBADF:
/* FIXME: should we die hard here? */
+ return MHD_ERR_BADF_; /* Fail hard */
break;
case EINVAL:
/* FIXME: optlen invalid, should at least log this, maybe die */
@@ -170,6 +173,7 @@ post_cork_setsockopt (struct MHD_Connection *connection,
_("optlen invalid: %s\n"),
MHD_socket_last_strerr_());
#endif
+ return MHD_ERR_INVAL_; /* Fail hard */
break;
case EFAULT:
/* wopsie, should at leats log this, FIXME: maybe die */
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [GNUnet-SVN] [libmicrohttpd] 115/154: gitignore build-aux., (continued)
- [GNUnet-SVN] [libmicrohttpd] 115/154: gitignore build-aux., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 132/154: reduce variable scope, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 131/154: toggle Naggle if and only if corking is not possible by other means, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 126/154: fixes, comments, FIXMEs, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 133/154: properly handle return value from send_on_connection2, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 130/154: always set nodelay, except if we cannot cork, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 135/154: add ways for application to control corking for upgraded sockets, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 138/154: mhd_send: fix failure to build, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 136/154: do it in both tests, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 139/154: Rename senfile_adapter to MHD_send_sendfile_ and remove duplicate prototype., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 151/154: mhd_send.c: for now, let EINVAL and EBADF fail hard.,
gnunet <=
- [GNUnet-SVN] [libmicrohttpd] 152/154: connection.c: remove dead code., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 154/154: Revert "connection.c: remove dead code.", gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 114/154: writev check, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 144/154: connection.c: remove dead code, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 153/154: Revert "mhd_send.c: for now, let EINVAL and EBADF fail hard.", gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 146/154: remove code, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 140/154: Mark function calls which could be removed as dead code., gnunet, 2019/08/19