[GNUnet-SVN] [taler-exchange] branch master updated: Addressing #5332

[gnunet]

This is an automated email from the git hooks/post-receive script.

marcello pushed a commit to branch master
in repository exchange.

The following commit(s) were added to refs/heads/master by this push:
     new 562b2cd  Addressing #5332
562b2cd is described below

commit 562b2cd18008ced56ee98a2516740b24736e08cf
Author: Marcello Stanisci <address@hidden>
AuthorDate: Mon Jul 2 11:13:28 2018 +0200

    Addressing #5332
---
 src/exchange-lib/testing_api_cmd_deposit.c           |  5 ++---
 src/exchange-lib/testing_api_cmd_fakebank_transfer.c | 11 ++++-------
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/src/exchange-lib/testing_api_cmd_deposit.c 
b/src/exchange-lib/testing_api_cmd_deposit.c
index 07895c1..4060e66 100644
--- a/src/exchange-lib/testing_api_cmd_deposit.c
+++ b/src/exchange-lib/testing_api_cmd_deposit.c
@@ -225,9 +225,6 @@ deposit_run (void *cls,
   ds->merchant_priv.eddsa_priv = *merchant_priv;
   GNUNET_free (merchant_priv);
 
-  /* FIXME: this looks very odd: why take times as relatives,
-   * just to convert them to absolutes soon after? */
-
   if (0 != ds->refund_deadline.rel_value_us)
   {
     refund_deadline = GNUNET_TIME_relative_to_absolute
@@ -402,6 +399,8 @@ deposit_traits (void *cls,
  * @param contract_terms contract terms to be signed over by the
  *        coin.
  * @param refund_deadline refund deadline, zero means 'no refunds'.
+ *        Note, if time were absolute, then it would have come
+ *        one day and disrupt tests meaning.
  * @param amount how much is going to be deposited.
  * @param expected_response_code expected HTTP response code.
  *
diff --git a/src/exchange-lib/testing_api_cmd_fakebank_transfer.c 
b/src/exchange-lib/testing_api_cmd_fakebank_transfer.c
index cdf3599..c7224ba 100644
--- a/src/exchange-lib/testing_api_cmd_fakebank_transfer.c
+++ b/src/exchange-lib/testing_api_cmd_fakebank_transfer.c
@@ -101,7 +101,10 @@ struct FakebankTransferState
   uint64_t serial_id;
 
   /**
-   * Exchange URL.  FIXME: explaing is needed.
+   * Exchange URL.  This value is fed to the bank when requesting
+   * the wire transfer; note: the bank needs it because a merchant
+   * might want to know which exchange performed a wire transfer to
+   * them, just by looking at bank records.
    */
   const char *exchange_url;
 
@@ -381,8 +384,6 @@ fakebank_transfer_traits (void *cls,
  *        debit_account_no at the bank.
  * @param auth_password password for @a auth_username.
  * @param exchange_url which exchange is involved in this transfer.
- *        This data is used for tracking purposes (FIXME: explain
- *        _how_).
  *
  * @return the command.
  */
@@ -444,8 +445,6 @@ TALER_TESTING_cmd_fakebank_transfer
  * @param auth_password password for @a auth_username.
  * @param subject wire transfer's subject line.
  * @param exchange_url which exchange is involved in this transfer.
- *        This data is used for tracking purposes (FIXME: explain
- *        _how_).
  *
  * @return the command.
  */
@@ -581,8 +580,6 @@ TALER_TESTING_cmd_fakebank_transfer_with_ref
  *        key of the tipping reserve.  This data will then used to
  *        construct the wire transfer subject line.
  * @param exchange_url which exchange is involved in this transfer.
- *        This data is used for tracking purposes (FIXME: explain
- *        _how_).
  * @param config_filename configuration file to use.
  *
  * @return the command.

-- 
To stop receiving notification emails like this one, please contact
address@hidden