[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[GNUnet-SVN] [gnurl] 143/178: ssh-libssh.c: fix left shift compiler warn
From: |
gnunet |
Subject: |
[GNUnet-SVN] [gnurl] 143/178: ssh-libssh.c: fix left shift compiler warning |
Date: |
Wed, 23 May 2018 12:26:18 +0200 |
This is an automated email from the git hooks/post-receive script.
ng0 pushed a commit to branch master
in repository gnurl.
commit 1156fdd01dcb7751081ea07603812666e5bbe6b7
Author: Daniel Stenberg <address@hidden>
AuthorDate: Thu May 3 22:16:57 2018 +0200
ssh-libssh.c: fix left shift compiler warning
ssh-libssh.c:2429:21: warning: result of '1 << 31' requires 33 bits to
represent, but 'int' only has 32 bits [-Wshift-overflow=]
'len' will never be that big anyway so I converted the run-time check to
a regular assert.
---
lib/ssh-libssh.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/ssh-libssh.c b/lib/ssh-libssh.c
index 9e6667295..34ef490c4 100644
--- a/lib/ssh-libssh.c
+++ b/lib/ssh-libssh.c
@@ -2425,8 +2425,7 @@ static ssize_t sftp_recv(struct connectdata *conn, int
sockindex,
ssize_t nread;
(void)sockindex;
- if(len >= (size_t)1<<32)
- len = (size_t)(1<<31)-1;
+ DEBUGASSERT(len < CURL_MAX_READ_SIZE);
switch(conn->proto.sshc.sftp_recv_state) {
case 0:
--
To stop receiving notification emails like this one, please contact
address@hidden
- [GNUnet-SVN] [gnurl] 125/178: cookies: remove unused macro, (continued)
- [GNUnet-SVN] [gnurl] 125/178: cookies: remove unused macro, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 94/178: openssl: Add support for OpenSSL 1.1.1 verbose-mode trace messages, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 128/178: TODO: CLOEXEC, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 118/178: os400.c: fix ASSIGNWITHINCONDITION checksrc warnings, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 137/178: TODO: remove configure --disable-pthreads, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 148/178: transfer: don't unset writesockfd on setup of multiplexed conns, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 151/178: github/lock: auto-lock closed issues after 90 days of inactivity, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 154/178: RELEASE-NOTES: typo, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 144/178: configure: only check for CA bundle for file-using SSL backends, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 147/178: configure: put CURLDEBUG and DEBUGBUILD in lib/curl_config.h, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 143/178: ssh-libssh.c: fix left shift compiler warning,
gnunet <=
- [GNUnet-SVN] [gnurl] 149/178: vtls: use unified "supports" bitfield member in backends, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 159/178: smb: reject negative file sizes, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 177/178: RELEASE-NOTES: 7.60.0 release, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 155/178: travis: add a build using WolfSSL, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 146/178: http: don't set the "rewind" flag when not uploading anything, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 99/178: tool_help: clarify --max-time unit of time is seconds, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 90/178: schannel: add support for CURLOPT_CAINFO, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 88/178: docs: fix typos, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 157/178: travis: add build using NSS, gnunet, 2018/05/23
- [GNUnet-SVN] [gnurl] 150/178: vtls: fix missing commas, gnunet, 2018/05/23