[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[GNUnet-SVN] r35988 - gnunet/src/nat
From: |
gnunet |
Subject: |
[GNUnet-SVN] r35988 - gnunet/src/nat |
Date: |
Thu, 25 Jun 2015 10:47:00 +0200 |
Author: wachs
Date: 2015-06-25 10:47:00 +0200 (Thu, 25 Jun 2015)
New Revision: 35988
Modified:
gnunet/src/nat/nat_stun.c
Log:
adding a first set of fixmes to stun code
Modified: gnunet/src/nat/nat_stun.c
===================================================================
--- gnunet/src/nat/nat_stun.c 2015-06-25 03:47:36 UTC (rev 35987)
+++ gnunet/src/nat/nat_stun.c 2015-06-25 08:47:00 UTC (rev 35988)
@@ -427,6 +427,7 @@
if(NULL == request) {
LOG (GNUNET_ERROR_TYPE_INFO, "Empty request\n");
+ /* FIXME clean up ? */
return;
}
@@ -433,6 +434,7 @@
if (NULL == addr) {
request->dns_active = NULL;
LOG (GNUNET_ERROR_TYPE_INFO, "Error resolving host %s\n",
request->stun_server);
+ /* FIXME clean up? */
return;
}
@@ -487,6 +489,7 @@
strcpy (server_copy, server);
}else{
GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "Failed to allocate
string");
+ /* FIXME: cleanup rh? */
return NULL;
}
@@ -495,7 +498,7 @@
rh->dns_active = GNUNET_RESOLVER_ip_get (rh->stun_server, AF_INET,
GNUNET_CONNECTION_CONNECT_RETRY_TIMEOUT,
&stun_dns_callback, rh);
+ /* FIXME: error handling NULL==dns_active, callback function? */
-
return rh;
-}
\ No newline at end of file
+}
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [GNUnet-SVN] r35988 - gnunet/src/nat,
gnunet <=