[GNUnet-SVN] r11980 - gnunet/src/transport

[gnunet]

Author: nevans
Date: 2010-06-27 16:25:45 +0200 (Sun, 27 Jun 2010)
New Revision: 11980

Modified:
   gnunet/src/transport/gnunet-service-transport.c
   gnunet/src/transport/plugin_transport_udp.c
Log:
coverity and codesonar fixes

Modified: gnunet/src/transport/gnunet-service-transport.c
===================================================================
--- gnunet/src/transport/gnunet-service-transport.c     2010-06-27 13:51:51 UTC 
(rev 11979)
+++ gnunet/src/transport/gnunet-service-transport.c     2010-06-27 14:25:45 UTC 
(rev 11980)
@@ -1108,7 +1108,10 @@
           GNUNET_free (data);
           return;
         }
-      tsize = tsize;
+
+      if (tsize < 1)
+        continue;
+
       transport_name = GNUNET_malloc(tsize + 1);
       memcpy(transport_name, &data[pos], tsize);
       pos = colon_pos + 1;

Modified: gnunet/src/transport/plugin_transport_udp.c
===================================================================
--- gnunet/src/transport/plugin_transport_udp.c 2010-06-27 13:51:51 UTC (rev 
11979)
+++ gnunet/src/transport/plugin_transport_udp.c 2010-06-27 14:25:45 UTC (rev 
11980)
@@ -830,7 +830,6 @@
   struct IPv6UdpAddress t6;
   void *arg;
   uint16_t args;
-
   void *addr_nat;
 
   addr_nat = NULL;
@@ -886,6 +885,11 @@
       arg = &t6;
       args = sizeof (t6);
     }
+  else
+    {
+      GNUNET_break (0);
+      return GNUNET_OK;
+    }
 
     GNUNET_log (GNUNET_ERROR_TYPE_INFO |
                      GNUNET_ERROR_TYPE_BULK,
@@ -1196,7 +1200,7 @@
       GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "udp",
                       _("Received PROBE REPLY from port %d on incoming port 
%d\n"), ntohs(((struct sockaddr_in *)sender_addr)->sin_port), sockinfo->port);
 #endif
-      if (sizeof(sender_addr) == sizeof(struct IPv4UdpAddress))
+      if ((sender_addr != NULL) && (sizeof(sender_addr) == sizeof(struct 
IPv4UdpAddress)))
         {
           memset(&addr_buf, 0, sizeof(addr_buf));
           if (NULL == inet_ntop (AF_INET,