gnunet-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Improving FCFS daemon


From: Schanzenbach, Martin
Subject: Re: Improving FCFS daemon
Date: Mon, 17 May 2021 11:36:19 +0000

I am not sure of the NULL is a requirement of va_arg.
The examples do not indicate that. And as I said the issue only arises when
the argument is coming from gettext.
So the issue lies somewhere else, but I do not know where.
Maybe this is a general gettext/va_arg incompatibility.

BR

> On 16. May 2021, at 23:13, Alessio Vanni <vannilla@firemail.cc> wrote:
> 
> Alessio Vanni <vannilla@firemail.cc> writes:
> 
>> Huh, that's strange. Admittedly, I didn't properly test successful
>> insertions, but I didn't get any crash on errors.
>> I'll check it out.
> 
> I pushed a fix for this.
> It was indeed because I had forgotten to put terminating NULL values in
> the `make_json' function calls.
> 
>> I'll add a section in the handbook after fixing the crash.
> 
> I also pushed a draft of a section dedicated to FCFSD.
> It was placed under GNS, as it's probably more appropriate.
> 
> I tried to be as informative as possible; please do provide feedback.
> 
> Thanks,
> A.V.
> 

Attachment: signature.asc
Description: Message signed with OpenPGP


reply via email to

[Prev in Thread] Current Thread [Next in Thread]