[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Properly initialize GNSRECORD even when outside of GNUnet (patch)
From: |
Christian Grothoff |
Subject: |
Re: Properly initialize GNSRECORD even when outside of GNUnet (patch) |
Date: |
Wed, 15 Jul 2020 20:15:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
Hi Alessio,
Makes sense, applied.
-Christian
On 7/15/20 5:40 PM, Alessio Vanni wrote:
> Hello,
>
> I've met an issue with GNSRECORD which is similar to [0] but a bit more
> subtle.
>
> As the commit message of the attached patch explains, when GNSRECORD is
> used after `GNUNET_OS_init' is called with a non-GNUnet project data,
> the necessary plugins are not loaded since the path is different.
>
> Naturally, since the plugins are not loaded, GNSRECORD will always fail
> when trying to operate on a record; that's how I discovered this issue:
> I was trying to parse a TXT record obtained from GNS, but it kept
> failing without a clear explanation. I had to go read the GNSRECORD
> source code to understand why I kept getting a NULL value.
>
> Admittedly, I didn't test these changes, however they seems pretty
> trivial so unless I misunderstood how the plugin loader works, they
> shouldn't cause any problem.
>
> Thanks,
> A.V.
>
> [0] https://lists.gnu.org/archive/html/gnunet-developers/2020-07/msg00009.html
>
0x939E6BE1E29FC3CC.asc
Description: application/pgp-keys
signature.asc
Description: OpenPGP digital signature