gnunet-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Git commit messages


From: Schanzenbach, Martin
Subject: Re: Git commit messages
Date: Wed, 27 May 2020 11:16:20 +0200

I would like to add something:

> On 27. May 2020, at 09:56, Schanzenbach, Martin <address@hidden> wrote:
> 
> B. Any other commit
> Please formulate your commit message in a way that makes it understandable 
> what component was changed,
> why it was changed and how. Possibly with an issue number if applicable:
> 
> Example:
> 
> "GNS: Added new record type BB. Fixes #4223"
> or
> "Buildsystem: Fixed build breaking with gcc-10"


Here, a message of "fix #1234" is NOT sufficient.
I have done so myself and have found ~50 in the current log since 0.12.1.
Those are not useful messages. Having to do to mantis to check the changes 
meaning
is quite annoying. Especially if the fix is not detailed in the bug report 
itself.
The commit message should explain the _change_. The bugreport should document 
the _reason_.

BR

Attachment: signature.asc
Description: Message signed with OpenPGP


reply via email to

[Prev in Thread] Current Thread [Next in Thread]