Re: [GNUnet-developers] 2 license headers to fix

[Schanzenbach, Martin]

> On 14. Jan 2019, at 22:25, Christian Grothoff <address@hidden> wrote:
> 
> Signed PGP part
> On 1/14/19 7:35 PM, address@hidden wrote:
>> I started a new branch with my work on spdx via scripts (there are 
>> applications, but our use-case
>> is simple enough to do it with pipes for now).
>> 
>> Odd results upon further expecting grep results:
>> - src/gns/nss/nss_gns.c  header has not been touched since 2012, exceptions 
>> 2013 and 2015.
>>   It states that it is parts of nss-gnss. "Parts taken from nss.c in 
>> nss-mdns" is not very
>>   specific. Which parts? Have they been changed? Or is it all functions?
> 
> I would say inspiration and generally how NSS plugins are written, the
> core logic is obviously different (not that I wrote the original code,
> but it has been rewritten a few times since the original adaptation). So
> it's probably not a copyright-relevant note, more of a "if you want to
> see what inspired us / have a reference for documentation, this is where
> you might want to look".

Yes. Originally I used the mdns nss plugin as a base, gutted it and replaced 
the mdns logic with GNS logic.
However, after removing the mdns logic, nothing more than function definitions 
remain(ed).

> 
>> - src/util/getopt.c  header should be double checked (typos, indentation, 
>> etc).
> 
> Ah, that one's a minor adaptation (last function in the file or so was
> added) of some code from gnulib (IIRC). To keep it
> close/more-or-less-identical to the original, it was not re-indented or
> typo-proved.
> 
> 
>

signature.asc
Description: Message signed with OpenPGP