Re: [GNUnet-developers] using $TMPDIR instead of /tmp

[Christian Grothoff]

On 05/05/2018 03:03 PM, Nils Gillmann wrote:
> Christian Grothoff transcribed 3.0K bytes:
>> On 05/05/2018 02:41 PM, Nils Gillmann wrote:
>>>> I grepped for "/tmp" in "src" and a not so small number of files was 
>>>> returned,
>>>> which is why I asked.
>>>> I didn't check the context in the files so far, but it is correct that I
>>> I checked the file name context, and 99% are tests. Even then we should not
>>> use /tmp, so I'll check that soon'ish.
>>>
>>
>> Agreed, it would be great if you could change the tests to use the
>> disk.c functionality.
> 
> actually some of them do.
> 
> test_plugin_namecache.c:
> 
> GNUNET_DISK_directory_remove ("/tmp/gnunet-test-plugin-namecache-sqlite");
> 
> or did I look at the wrong code?

That uses another part of disk.c, not the /tmp-file generation. This
code above would have to be changed to obtain the _actual_ directory
name from the configuration, then rm -rf, and then free the string.
Tedious work.

signature.asc
Description: OpenPGP digital signature