[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNUnet-developers] A few comments and fixes to the documentation

From: Christian Grothoff
Subject: Re: [GNUnet-developers] A few comments and fixes to the documentation
Date: Mon, 8 Jan 2018 01:17:29 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 01/07/2018 05:57 PM, ng0 wrote:
>> Well, it may not be technically unit-testing, but the common style we
>> follow in this case is to create a test (that is run as part of 'make
>> check') which simply launches the peer (via ARM), runs the tests, and
>> then stops the peer.  For multi-peer tests, we have the testbed API (C)
>> or the gnunet-testbed-profiler (shell scripts, etc).
>> But aside from this slightly more evolved setup/teardown, it is best
>> practice to write such tests to try to achieve code coverage, just like
>> you might do with unit tests.
> Wouldn't in the case of guile tests that are written with some
> guile specific test framework be better?

Well, regardless of what *testing* framework you use, you do need to
launch GNUnet peers, which is not a trivial process. So your testing
framework should integrate with GNUnet-testbed (be it by exec'ing
gnunet-testbed-profiler or by linking against libgnunettestbed) to
launch the peers.

So yes, maybe you don't launch the tests as part of 'make check' because
you have a different build system, but the rest of what I wrote should
still apply.

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]