Re: [GNUnet-developers] a couple of fixes for abstract sockets on linux

[Christian Grothoff]

Hi Andrew,

Thanks for looking into this!

The first patch looks OK, I'll likely apply it when I had the time to
test it a bit.  The second one is technically OK, however there was
a very different suggestion before to get rid of abstract sockets so
that we can use the file system for access control:
https://gnunet.org/bugs/view.php?id=2887

Thus, I think that patch might rather be useful as a hints for us as to
where we'd need to make changes to address #2887.  As that's a rather
different direction, I'm likely not going to apply your second patch for
now.

I've attached both of your patches to #2887 for future reference.

Happy hacking!

Christian

On 09/26/2013 03:49 PM, Andrew Cann wrote:
> 
> These two patches fix a couple of bugs in the way abstract unix domain
> sockets are used on Linux.
> 
> https://canndrew.org/misc/trim_abstract_socket_paths.diff
> 
> This changes the addrlen argument passed to the connect, bind and sendto
> syscalls to reflect the length of the string in sockaddr_un.sun_path. I
> was trying to talk to GNUnet services using socat and discovered that it
> expects abstract sockets to be created this way and won't connect
> otherwise. Looking at some other programs that I could talk to using
> socat (dbus, X11), this is how they create abstract sockets as well.
> 
> https://canndrew.org/misc/dont_drop_first_character_of_abstract_socket_path.diff
> 
> Currently when using an abstract socket the first character of the path
> get chopped off. So, for example, trying to create a socket called
> "/tmp/gnunet-service-foo.sock" results in a socket called
> "tmp/gnunet-service-foo.sock". This patch fixes this.
> 
>  - Andrew
> 
> 
> 
> _______________________________________________
> GNUnet-developers mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/gnunet-developers

0x48426C7E.asc
Description: application/pgp-keys

signature.asc
Description: OpenPGP digital signature