[GNUnet-developers] Content Migration

[Hendrik Pagenhardt]

Hello,

from looking at the source of "insertContent" in manager.c I get the 
impression that it is possible to overwrite an indexed CHK block with a 
migrated one. If the priority is big enough to jump over the migration 
threshold the hash is looked up and as an indexed block has an empty 
content field it is not recognized as a duplicate. So the index pointer 
block will be overwritten and becomes a "normal" CHK block. I think 
that's a bad thing, as the block takes more space then.

I'd suggest adding a test after reading the old content to check whether 
it's an index block and then set the duplicate output param accordingly.

Hendrik