Re: [GNUnet-developers] header include cleanup

[Christian Grothoff]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 02 March 2003 01:02 am, Glenn McGrath wrote:
> I think its good programming practice to avoid including headers from
> within other header files if possible.

True.

> Including header files inside header can quickly make it hard to track
> down exactly where a file is being #included from.
>
> With the attached patch i have removed as many include statments as
> possible from the include files and replaced them with equivalent
> statments in the .c file.

Patch has been applied to CVS.

> I think there are probably unneeded include statments in some .c files,
> i will work on identifying and fixing them next.
>
> Once that is done i think it would be good to declare _HEADERS in the
> Makefile.am which would avoid needing Makefile.am's in each
> ./src/include/ directory.

I'm not sure if automake can handle that with the headers being in another 
directory. But currently, "make distcheck" is broken because of our 
EXTRA_DISTing the header files in "include". If you can fix that and have 
"make dist" still work, go for it.

Christian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE+Yapp9tNtMeXQLkIRArMCAKCIk+PB+pIIjdhlabdNL2DC/0lIbQCffbvO
n5S5bJYC6tx72xX9d5Q/6qc=
=dFgf
-----END PGP SIGNATURE-----