Re: [PATCH v1 0/5] Fix LVM2 again.

[Adrien 'neox' Bourmault]

Le vendredi 13 décembre 2024 à 14:58 +0100, Denis 'GNUtoo' Carikli a
écrit :
> Hi,
> 
> The details are inside the commit message, but we have many strange
> thing that led to the LVM2 bug not being fixed. This should fix it
> now
> but it's untested. Since neox can easily reproduce the bug it would
> be
> nice if neox could test it.
> 
> I'll also try to test it later on, but as explained in more details
> in
> the commit messages, the automatic test that uses QEMU and GRUB is
> also broken. I'll try to find the time to fix it later on (I want to
> keep Trisquel 11 the tests). We also need to find a way to test with
> a
> broken grub configuration to make sure the test keeps working.
> 
> Also, I looked for my old versions and for reviews on the mailing
> list
> but I coun't find anything, so it's probably a good thing if we stick
> to the mailing list for reviews (but not necessarily discussions) in
> the future. This way the tests could also test the real patch set
> instead of testing previous versions or partial parts (like just the
> config) like I ended up doing.
> 
> Denis 'GNUtoo' Carikli (5):
>   website: history: Add git history of website-build.
>   resources: grub: config: (ab)use shellcheck to check it.
>   resources: grub: config: fix wrong dev/device variable.
>   resources: grub: config: fix non-working regexp.
>   resources: grub: config: unify dev and devices variables.
> 
>  resources/grub/config/grub.cfg  | 16 ++++++++++------
>  tests/lint                      |  1 +
>  website/history/git-history.dot | 15 ++++++++++++---
>  3 files changed, 23 insertions(+), 9 deletions(-)
> 
> 
> base-commit: 5c867e65f60dba70662afd1d8c3486b6134bcf1e

Thanks for the fixes. I tested that (successfully) and just pushed into
main.
-- 
Adrien Bourmault
Maintainer, GNU Boot project
Associate member, Free Software Foundation
GPG : E23C26A5DEEEC5FA9CDDD57A57BC26A3687116F6

signature.asc
Description: This is a digitally signed message part